michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250805377
########## File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java ########## @@ -533,6 +496,58 @@ private void doSendx(ActiveMQDestination destination, } } + private void checkDestination(ActiveMQDestination destination, + SimpleString address, + ClientSession clientSession) throws JMSException { + + // TODO: What to do with FQQN + if (!connection.containsKnownDestination(address)) { + try { + ClientSession.AddressQuery addressQuery = clientSession.addressQuery(address); + + boolean addressExists = addressQuery.isExists(); + // first we check the address existence, and autoCreate it if allowed in case it does not exists + + if (!addressExists && addressQuery.isAutoCreateAddresses()) { Review comment: We should only create an address for a JMSQueue if we can create both the Address and Queue, else you could end up creating an address, but not the queue (old code had correct logic here) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services