michaelandrepearce commented on a change in pull request #2520: ARTEMIS-2238
Enhancement to queueQuery on producer
URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r250809792
##########
File path:
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQMessageProducer.java
##########
@@ -533,6 +499,67 @@ private void doSendx(ActiveMQDestination destination,
}
}
+ private void checkDestination(ActiveMQDestination destination,
+ SimpleString address,
+ ClientSession clientSession) throws
JMSException {
+
+ // TODO: What to do with FQQN
+ if (!connection.containsKnownDestination(address)) {
+ try {
+ ClientSession.AddressQuery addressQuery =
clientSession.addressQuery(address);
+
+ boolean addressExists = addressQuery.isExists();
+ // first we check the address existence, and autoCreate it if
allowed in case it does not exists
+
+ if (!addressExists && addressQuery.isAutoCreateAddresses()) {
+
+ if (destination.isQueue() &&
!addressQuery.isAutoCreateQueues()) {
+ if (logger.isDebugEnabled()) {
+ logger.debug("Address " + address + " was not created
because we would not have permission to create queue");
+ }
+ // if it can't create the internal queue on JMS Queues, why
bother creating the address, just mark it false now
+ addressExists = false;
+ } else {
+ RoutingType addressType = destination.isQueue() ?
RoutingType.ANYCAST : RoutingType.MULTICAST;
+ clientSession.createAddress(address, addressType, true);
+ addressExists = true;
+ }
+ }
Review comment:
add else clause here with throws:
then on debugging from logs with stack trace it would make it easier, as
would get line where it errored out so could figure out. Also could then allow
a better description so end users understand better, e.g.
depending on destination.isQueue()
"Queue " + address + " does not exist, auto create addresses is disabled."
"Topic " + address + " does not exist, auto create addresses is disabled."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
