franz1981 commented on a change in pull request #2520: ARTEMIS-2238 Enhancement 
to queueQuery on producer
URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251195219
 
 

 ##########
 File path: 
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java
 ##########
 @@ -397,6 +380,55 @@ public MessageProducer createProducer(final Destination 
destination) throws JMSE
       }
    }
 
+   void checkDestination(ActiveMQDestination destination) throws JMSException {
+      SimpleString address = destination.getSimpleAddress();
+      // TODO: What to do with FQQN
+      if (!connection.containsKnownDestination(address)) {
+         try {
 
 Review comment:
   Don't know: the higher level method is already packing everything in a 
separate method: why wait another PR just to do the same?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to