franz1981 commented on a change in pull request #2520: ARTEMIS-2238 Enhancement to queueQuery on producer URL: https://github.com/apache/activemq-artemis/pull/2520#discussion_r251195297
########## File path: artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java ########## @@ -397,6 +380,55 @@ public MessageProducer createProducer(final Destination destination) throws JMSE } } + void checkDestination(ActiveMQDestination destination) throws JMSException { Review comment: I understand it and agree, but depends on the visibility/importance of the method: this one if overridden really breaks badly pretty much everything. I won't never use final for private methods, but for package private ie near-public and important ones, yes. As I've said is just style comment, I'm already happy with the PR :+1: ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services