michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252177045
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerSessionImpl.java
##########
@@ -540,6 +541,12 @@ public ServerConsumer createConsumer(final long
consumerID,
props.putSimpleStringProperty(ManagementHelper.HDR_FILTERSTRING,
filterString);
}
+ String protocolName = remotingConnection.getProtocolName();
+ if (protocolName != null &&
protocolName.equals(ProtocolName.MQTT_PROTOCOL_NAME.getProtocolName().toString()))
{
Review comment:
This is protocol specific logic. This MUST not ever live in core modules.
Protocol specific logic can ONLY reside in its protocol module
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
