michaelandrepearce commented on a change in pull request #2528: ARTEMIS-2226
last consumer connection should close the previous consu…
URL: https://github.com/apache/activemq-artemis/pull/2528#discussion_r252900294
##########
File path:
artemis-protocols/artemis-mqtt-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/mqtt/MQTTSession.java
##########
@@ -30,10 +30,12 @@
public class MQTTSession {
- static Map<String, MQTTSessionState> SESSIONS = new ConcurrentHashMap<>();
+ private static Map<String, MQTTSessionState> SESSIONS = new
ConcurrentHashMap<>();
Review comment:
Looking at this im bit worried that this is a static in first place, e.g.
its possible to have multiple embedded brokers, in that case each broker
shouldnt share any state, by being static means they would.
really should be held as a non static at level above such as
MQTTProtocolHandler
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
