clebertsuconic commented on a change in pull request #2541: ARTEMIS-2246
clarify max-disk-usage 'default'
URL: https://github.com/apache/activemq-artemis/pull/2541#discussion_r254499204
##########
File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd
##########
@@ -749,10 +749,10 @@
</xsd:annotation>
</xsd:element>
- <xsd:element name="max-disk-usage" type="xsd:int" default="90"
maxOccurs="1" minOccurs="0">
+ <xsd:element name="max-disk-usage" type="xsd:int" default="100"
maxOccurs="1" minOccurs="0">
Review comment:
Why you are disabling by default anyway? I would expect the system to block
on a disk full, before it got full.
I think there's a good value on having the system protected against disk
full, out of box. We could increase the default to 99 and users can still
disable if they would rather take the risk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
