clebertsuconic commented on a change in pull request #2541: ARTEMIS-2246 
clarify max-disk-usage 'default'
URL: https://github.com/apache/activemq-artemis/pull/2541#discussion_r254735557
 
 

 ##########
 File path: artemis-server/src/main/resources/schema/artemis-configuration.xsd
 ##########
 @@ -749,10 +749,10 @@
             </xsd:annotation>
          </xsd:element>
 
-         <xsd:element name="max-disk-usage" type="xsd:int" default="90" 
maxOccurs="1" minOccurs="0">
+         <xsd:element name="max-disk-usage" type="xsd:int" default="100" 
maxOccurs="1" minOccurs="0">
 
 Review comment:
   I will merge it..but I will add a PR to have a system property to change the 
value to -1, and have the maven settings setting it to 100.
   
   Some of my CI boxes are close to 90... so this would break things as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to