clebertsuconic commented on a change in pull request #2564: ARTEMIS-2183
Useless statement in public synchronized List
URL: https://github.com/apache/activemq-artemis/pull/2564#discussion_r259932919
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java
##########
@@ -190,9 +190,7 @@ private void decrementRefCount(MessageReference refmsg) {
@Override
public synchronized List<MessageReference> getRelatedMessageReferences() {
- List<MessageReference> listRet = new LinkedList<>();
Review comment:
I'm not sure this is a good idea. I think this needs to be isolated.
at least that would break synchronization on the list.. a method listing
JSon while the transaction still being appeneded.. you could get consequences
almost impossible to test.
Can you close this PR pretty please?
I appreciate you know the codebase well... but this was meant to be
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
