clebertsuconic commented on a change in pull request #2564: ARTEMIS-2183
Useless statement in public synchronized List
URL: https://github.com/apache/activemq-artemis/pull/2564#discussion_r259960277
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RefsOperation.java
##########
@@ -190,9 +190,7 @@ private void decrementRefCount(MessageReference refmsg) {
@Override
public synchronized List<MessageReference> getRelatedMessageReferences() {
- List<MessageReference> listRet = new LinkedList<>();
Review comment:
OHHHHHH... I see now...
I was reading the method as it was supposed to be written:
```java
List<MessageReference> listRet = new LinkedList<>();
listRet.addAll(refsToAck);
return listRet;
```
@orpiske this is how this method was supposed to be written ^^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
