Yes, all fixed And also i review a PR with wrong license headers
Cheers Emmanuel On 08/06/2019 23:30, [email protected] wrote: > Would that also address the other rat failures that Robbie found? > > > > > Get Outlook for Android > > > > > > > > On Fri, Jun 7, 2019 at 12:44 PM +0100, "Emmanuel Hugonnet" > <[email protected]> wrote: > > > > > > > > > > > Hello, > > I've sent the PR https://github.com/wildfly/wildfly-common/pull/46 and I'll > try to have it merged with a release today. > > Cheers, > > Emmanuel > > On 07/06/2019 11:53, Robbie Gemmell wrote: >> Here is the RAT output for wildfly-commons 1.5.1.Final (version used >> in Artemis), from adding the RAT plugin and running "mvn >> apache-rat:check" on the module: >> https://paste.apache.org/BzlS >> >> 16 files were flagged unknown, 15 of which just have no header (5 look >> like just empty build marker files), plus the 1 >> CompositeCharSequenceTestCase.java test class Michael noted which has >> the LGPL header. >> >> Robbie >> >> On Thu, 6 Jun 2019 at 21:12, Michael André Pearce >> wrote: >>> I haven’t checked all the files, i don’t have time. But simply the parent >>> wildfly project is LPGL and I’ve found one file with LGPL, this is a >>> concern, and going forwards this is risky as they may move more files from >>> Wildfly project into it. >>> >>>> On 6 Jun 2019, at 21:10, Michael André Pearce wrote: >>>> >>>> There is a class in there which was taken from wildfly but keeps its gnu >>>> license (as it has to) >>>> https://github.com/wildfly/wildfly-common/blob/d8397e1174a193aaab5db510da514f6039be6742/src/test/java/org/wildfly/common/string/CompositeCharSequenceTestCase.java >>>> >>>> As such even so they declare it Apache, it isn’t because inside is code >>>> that is LPGL from wildly. >>>> >>>>> On 6 Jun 2019, at 21:06, Justin Bertram wrote: >>>>> >>>>> This was the dependency added: >>>>> >>>>> >>>>> org.wildfly.common >>>>> wildfly-common >>>>> >>>>> >>>>> Wildfly Common is ASL 2. See >>>>> https://github.com/wildfly/wildfly-common/blob/master/LICENSE. >>>>> >>>>> I could see your point if a dependency on org.wildfly:wildfly-parent was >>>>> added as that is LGPL as you noted. >>>>> >>>>> At this point I don't see a problem. >>>>> >>>>> >>>>> Justin >>>>> >>>>> On Thu, Jun 6, 2019 at 3:02 PM Michael André Pearce >>>>> wrote: >>>>> >>>>>> Wildfly project: >>>>>> >>>>>> https://github.com/wildfly/wildfly/blob/master/LICENSE.txt >>>>>> >>>>>> >>>>>>> On 6 Jun 2019, at 21:01, Justin Bertram wrote: >>>>>>> >>>>>>> Are you sure about that? Wildfly Common is ASL 2. See >>>>>>> https://github.com/wildfly/wildfly-common. >>>>>>> >>>>>>> >>>>>>> Justin >>>>>>> >>>>>>> On Thu, Jun 6, 2019 at 2:47 PM Michael André Pearce >>>>>>> wrote: >>>>>>> >>>>>>>> http://www.apache.org/legal/resolved.html >>>>>>>> >>>>>>>> It’s a category x, in my understanding. >>>>>>>> >>>>>>>>> On 6 Jun 2019, at 20:46, Michael André Pearce < >>>>>>>> [email protected]> wrote: >>>>>>>>> Hi All, >>>>>>>>> >>>>>>>>> It seems https://github.com/apache/activemq-artemis/pull/2661 >>>>>>>> introduced an LPGL dependency into ActiveMQ Artemis. >>>>>>>>> Can we please revert this. >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> Mike > > > > > >
signature.asc
Description: OpenPGP digital signature
