-1

Unfortunately I found 3 files with missing headers:
activemq-web/src/main/resources/org/apache/activemq/web/prototype.js
activemq-unit-tests/src/test/java/org/apache/activemq/usecases/QueueBrowsingDisableConcurrentStoreAndDispatchTest.java
activemq-unit-tests/src/test/java/org/apache/activemq/usecases/UsageBlockedDispatchConcurrentStoreAndDispatchFalseTest.java

However, I did run through the smoke tests and they look good, Jenkins
looks good, and I also verified the tag against a bunch of my own tests and
everything looked good. So if we re-cut the release with those 3 files
fixed I would change my vote unless something else comes up.

On another note, for the next release it probably makes sense to fix our
Maven build to run the rat check goal when doing a release to catch this.

On Wed, Jun 24, 2020 at 1:00 AM Jean-Baptiste Onofre <[email protected]>
wrote:

> Hi everyone,
>
> I'm submitting (finally ;)) ActiveMQ 5.16.0 release to your vote.
>
> This release is an important milestone as the runtime supports JDK 11. The
> full build with JDK 11 is planned for 5.17.0.
>
> It also includes bunch of fixes, improvements and much more.
>
> For your information, once this vote will pass, I will create
> activemq-5.16.x branch and I will move master branch to version 5.17.0.
>
> Please take a look on the Release Notes for details:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12341032
> <
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210&version=12341032
> >
>
> The Maven staging repository is:
> https://repository.apache.org/content/repositories/orgapacheactivemq-1212/
> <
> https://repository.apache.org/content/repositories/orgapacheactivemq-1212/
> >
>
> The dist staging repository is:
> https://dist.apache.org/repos/dist/dev/activemq/activemq/5.16.0/ <
> https://dist.apache.org/repos/dist/dev/activemq/activemq/5.16.0/>
>
> Git tag:
> activemq-5.16.0
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] -1 Don't approve the release (please provide specific comments)
>
> This vote will be open for at least 72 hours.
>
> Thanks !
> Regards
> JB

Reply via email to