It depends on the size of the PR. If it's something simple, low risk I would say we can wait for it.. however if it's something major and has some risk, I would prefer having a lot of full testsuite runs (that I do on a CI I have access) between when a major PR is merged and a release.
if you're adding a service loader without changing much at the server dependencies we can merge it... otherwise we can wait another release. (we don't need to wait 2 months for another release... we can make another whenever needed). On Thu, Feb 4, 2021 at 10:43 AM Christoph Läubrich <m...@laeubi-soft.de> wrote: > > It might be too late, but I'm currently investigate in an issue related > to [1] and like to provide a PR the next days that add support of > providing sasl mechanism through java-service-loader is there any chance > (assuming I got everything done in time) to include this in the next > release? > > > [1] https://issues.apache.org/jira/browse/ARTEMIS-33 > > Am 04.02.21 um 16:36 schrieb Clebert Suconic: > > everythign is merged... > > > > There is one final issue I'm after though.. .I have made libaio to > > close files asynchronously. I have seen an eventual failure on the > > testsuite (well, a warning to be more precise) on waiting to close > > files... that I am after. > > > > > > I will postpone this release to monday to give me time to find that > > issue before I release. Sorry for any inconvenience. > > > > On Mon, Feb 1, 2021 at 3:42 AM Emmanuel Hugonnet <ehugo...@redhat.com> > > wrote: > >> > >> Hello, > >> It would be nice if we could have > >> https://github.com/apache/activemq-artemis/pull/3412 in this release :) > >> Cheers, > >> Emmanuel > >> > >> Le 29/01/2021 à 17:53, Clebert Suconic a écrit : > >>> I plan to do an artemis release some time next week (around Wed) > >>> > >>> I will check on pending PRs... (please give me a hand also on merging > >>> stuff) > >>> > >>> if there's anything you need my attention on a particular PR please > >>> mention it here on this thread.. > >>> > >>> > >>> I will make sure we merge the Jakarta integration before this release BTW. > >>> > >>> > >>> I am also postponing JDK upgrade for a release after this, given > >>> Wildfly (Emmanuel) request to keep the next release as JDK 8 due to > >>> JavaEE needs. > >>> > >>> > >>> > >> > > > > -- Clebert Suconic
