Thanks a lot Chris !

I’m moving forward on the javadoc.

Regards
JB

> Le 21 mai 2021 à 12:21, Christopher Shannon <christopher.l.shan...@gmail.com> 
> a écrit :
> 
> I'm taking a look now. The main thing I notice is the assembly plugin
> change has caused my build to break with a group id is too big error (which
> I've seen before). i can push a fix for it.
> 
> On Fri, May 21, 2021 at 5:25 AM Jean-Baptiste Onofre <j...@nanthrax.net>
> wrote:
> 
>> Hi everyone,
>> 
>> I created PR https://github.com/apache/activemq/pull/647 <
>> https://github.com/apache/activemq/pull/647> related to JDK11 build
>> support.
>> 
>> This PR includes:
>> 1. Add JAXB and related wherever it’s required
>> 2. Update of most of the Maven plugins
>> 3. Refactoring of the OSGi headers and use of maven-bundle-plugin 5.1.2 to
>> fix the OSGi headers
>> 4. Upgrade Jenkinsfile to use JDK11
>> 5. Some code style change (to prepare/test the changes)
>> 6. The build passed on my machine, but I ignored two tests failing on
>> Jenkins:
>>        - activemq-mqtt: MQTTConnectTest#testParallelConnectPlain
>>        - activemq-runtime-config: SpringBeanTest#testModifiable
>> 
>> If there’s no objection, I would like to squash & merge the PR as it
>> blocks me to move forward on other PRs (spring5, camel cleanup, etc).
>> 
>> No objection ?
>> 
>> Thanks,
>> Regards
>> JB
>> 
>> 

Reply via email to