I agree with Chris that it should be a 7.0 removal. I think we could address the issue in the short-term with the following non-user impacting changes:
1. Update @Deprecated to include ‘for removal’ 2. Exclude the unit tests for the deprecated-for-removal features so they don’t run for the developer on-the-desktop scenario 3. Enable those unit tests via Maven profile for Jenkins CI/CD -Matt > On May 1, 2025, at 3:42 AM, Jean-Louis Monteiro <jlmonte...@tomitribe.com> > wrote: > > I think it's outdated anyways, so removing it with the upcoming 6.2 is fine > in my opinion. > Should we create a VOTE thread for it or I can go ahead and create a PR for > it? > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Thu, May 1, 2025 at 7:40 AM Jean-Baptiste Onofré <j...@nanthrax.net> wrote: > >> Hi >> >> I'm fine to remove it, but the question is in which target. This >> clearly requires a major release. >> >> I'm fine to do it on 6.2.0 (not necessary on 7.0.0). Or we have to >> change the scope of 7.0.0. >> >> Regards >> JB >> >> On Wed, Apr 30, 2025 at 7:44 AM Jean-Louis Monteiro >> <jlmonte...@tomitribe.com> wrote: >>> >>> Hi, >>> >>> I've been having test failures with the MulticastTransportTest. >>> 2 of the 3 tests were removed as part of >>> https://issues.apache.org/jira/browse/AMQ-4973 >>> >>> The 2 transports were marked as deprecated about 10 years ago, so is it >>> time to remove them? >>> I'm happy to create an issue and send a PR to remove them. >>> >>> If not, then we might want to also remove the last test from >>> MulticastTransportTest (aka remove the test altogether because there >> would >>> be no other test to run). >>> >>> I keep having this problem >>> >>> 2025-04-30 07:41:51,184 [main ] - INFO MulticastTransportTest >>>> - Producer using URI: multicast://224.1.2.3:6255 >>>> 2025-04-30 07:41:51,192 [main ] - INFO >> MulticastTransportTest >>>> - Producer using URI: multicast://224.1.2.3:6255 >>>> 2025-04-30 07:41:51,197 [main ] - INFO >> MulticastTransportTest >>>> - Producer using URI: multicast://224.1.2.3:6255 >>>> 2025-04-30 07:41:51,203 [main ] - INFO UdpTestSupport >>>> - About to send: ConsumerInfo {commandId = 0, responseRequired = >>>> false, consumerId = null, destination = null, prefetchSize = 3456, >>>> maximumPendingMessageLimit = 0, browser = false, dispatchAsync = false, >>>> selector = Cheese, clientId = null, subscriptionName = null, noLocal = >>>> false, exclusive = true, retroactive = false, priority = 0, brokerPath >> = >>>> null, optimizedAcknowledge = false, noRangeAcks = false, >>>> additionalPredicate = null, networkConsumerIds = null} >>>> 2025-04-30 07:41:56,199 [24.1.2.3:6255@0] - INFO UdpTestSupport >>>> - ### Received error: java.net.SocketTimeoutException: Receive >>>> timed out >>>> 2025-04-30 07:41:56,199 [24.1.2.3:6255@0] - INFO UdpTestSupport >>>> - Producer exception: java.net.SocketTimeoutException: Receive >>>> timed out >>>> java.net.SocketTimeoutException: Receive timed out >>>> at >>>> java.base/sun.nio.ch >> .DatagramChannelImpl.trustedBlockingReceive(DatagramChannelImpl.java:703) >>>> at >>>> java.base/sun.nio.ch >> .DatagramChannelImpl.blockingReceive(DatagramChannelImpl.java:633) >>>> at >>>> java.base/sun.nio.ch >> .DatagramSocketAdaptor.receive(DatagramSocketAdaptor.java:240) >>>> at java.base/java.net.DatagramSocket.receive(DatagramSocket.java:700) >>>> at >>>> >> org.apache.activemq.transport.udp.CommandDatagramSocket.read(CommandDatagramSocket.java:71) >>>> at >>>> >> org.apache.activemq.transport.udp.UdpTransport.run(UdpTransport.java:150) >>>> at java.base/java.lang.Thread.run(Thread.java:840) >>>> java.net.SocketTimeoutException: Receive timed out >>>> at >>>> java.base/sun.nio.ch >> .DatagramChannelImpl.trustedBlockingReceive(DatagramChannelImpl.java:703) >>>> at >>>> java.base/sun.nio.ch >> .DatagramChannelImpl.blockingReceive(DatagramChannelImpl.java:633) >>>> at >>>> java.base/sun.nio.ch >> .DatagramSocketAdaptor.receive(DatagramSocketAdaptor.java:240) >>>> at java.base/java.net.DatagramSocket.receive(DatagramSocket.java:700) >>>> at >>>> >> org.apache.activemq.transport.udp.CommandDatagramSocket.read(CommandDatagramSocket.java:71) >>>> at >>>> >> org.apache.activemq.transport.udp.UdpTransport.run(UdpTransport.java:150) >>>> at java.base/java.lang.Thread.run(Thread.java:840) >>>> >>>> junit.framework.AssertionFailedError: Should have received a Command by >>>> now! >>>> >>>> at junit.framework.Assert.fail(Assert.java:57) >>>> at junit.framework.Assert.assertTrue(Assert.java:22) >>>> at junit.framework.Assert.assertNotNull(Assert.java:256) >>>> at junit.framework.TestCase.assertNotNull(TestCase.java:399) >>>> at >>>> >> org.apache.activemq.transport.udp.UdpTestSupport.assertCommandReceived(UdpTestSupport.java:260) >>>> at >>>> >> org.apache.activemq.transport.udp.UdpTestSupport.testSendingSmallMessage(UdpTestSupport.java:68) >>>> at >> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native >>>> Method) >>>> at >>>> >> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) >>>> at >>>> >> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>> at java.base/java.lang.reflect.Method.invoke(Method.java:569) >>>> at junit.framework.TestCase.runTest(TestCase.java:177) >>>> at junit.framework.TestCase.runBare(TestCase.java:142) >>>> at junit.framework.TestResult$1.protect(TestResult.java:122) >>>> at junit.framework.TestResult.runProtected(TestResult.java:142) >>>> at junit.framework.TestResult.run(TestResult.java:125) >>>> at junit.framework.TestCase.run(TestCase.java:130) >>>> at junit.framework.TestSuite.runTest(TestSuite.java:241) >>>> at junit.framework.TestSuite.run(TestSuite.java:236) >>>> at >>>> >> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:90) >>>> at org.junit.runner.JUnitCore.run(JUnitCore.java:137) >>>> at >>>> >> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69) >>>> at >>>> >> com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38) >>>> at >>>> >> com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11) >>>> at >>>> >> com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35) >>>> at >>>> >> com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:232) >>>> at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:55) >>>> >>>> >>>> >>> >>> >>> >>> -- >>> Jean-Louis Monteiro >>> http://twitter.com/jlouismonteiro >>> http://www.tomitribe.com >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org >> For additional commands, e-mail: dev-h...@activemq.apache.org >> For further information, visit: https://activemq.apache.org/contact >> >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@activemq.apache.org For additional commands, e-mail: dev-h...@activemq.apache.org For further information, visit: https://activemq.apache.org/contact
