Hi Trista,

[1] When AGE Viewer was donated to Apache, it already supported both
AgensGraph and AGE as backend database connections. To completely remove
all references to AgensGraph would mean removing AGE Viewer's ability to
connect to AgensGraph as a backend database.
[2] Before AGE was donated to Apache, its name was AgensGraph-Extension. In
the proposal process, the community determined that the project had to be
renamed. AgensGraph itself is not a part of Apache.

Thanks,
Josh

On Thu, Feb 3, 2022 at 4:28 AM Juan Pan <panj...@apache.org> wrote:

> Hi Josh,
>
>
> Actually, our ppmc of AGE more care about AGE project (its brand,
> community, etc.) rather than AgensGraph.
> My suggestion is to erase the marks around them as possible as we can for
> safety, based on
> 1. Why do our AGE viewer need to be compatible with AgensGraph? Is
> AgensGraph part of this incubator project?
> 2. AgensGraph is suggested to be renamed in gene...@incubator.ml by other
> IPMCs, I remember?
>
>
> Best,
> Trista
>
> ------------------------------------------------------------------------------
> Trista Pan, Twitter: @tristaZero
>
>
> On 02/3/2022 01:26,Josh Innis<joshin...@gmail.com> wrote:
> HI Juan,
>
> 1. AGE Viewer connects to two databases: Apache AGE and AgensGraph. No code
> from AgensGraph resides in AGE Viewer. When AGE Viewer is connected to
> AgensGraph, is it an issue if AGE Viewer gives a context specific language
> in code or in messages given to the user?
>
> For example:
> backend/src/util/JsonBuilder.js:66
> if (flavor === 'AGE') {
> return AGECreateEdge(client, graphPathStr, createQ);
> } else {
> return AgensGraphCreateEdge(client, graphPathStr, createQ);
> }
>
> Since AgensGraphCreateEdge is used only when AGE Viewer is connected to
> AgensGraph, is it necessary to change it?
>
> 2. Some of the results are for modules that handles the connection to the
> database. It looks like this is from when the source code was originally
> donated to Apache from Bitnine. These modules probably need to be renamed
> to something generic.
>
> 3. Since AGE Viewer originally connected to AgensGraph and extended to
> support AGE there are some hardcoded values that need to be altered.
>
> For example:
> frontend/src/components/frame/presentations/ServerStatusFrame.jsx:86
> if (status === 'disconnected') {
> return (
> ...
> <h3>Connection Status</h3>
> <p>You are currently not connected to AgensGraph</p>
> ...
>
> This code displays a message to the user when there is a connection error.
> Personally, I think this needs a conditional expression for the type of
> database the user is connecting to, but if all references to Agensgraph
> need to be removed it could instead display: <p>You are currently not
> connected</p> for all database connection types.
>
> 4. Many of the results come from the file
> frontend/src/documents/tutorial/northwind.jsx. This file is a tutorial that
> shows how to use AGE Viewer with AgensGraph. Should this file be removed?
>
> On Wed, Feb 2, 2022 at 3:39 AM Juan Pan <panj...@apache.org> wrote:
>
> I also have no idea about this vote.
>
>
> I tracked the whole thread and found others raised some issues, but some
> have had no feedback so far. Could anyone sync me this vote is still in the
> process and double check the issue I mentioned?
>
>
> It is the first time for the community to release AGE-view. It is
> efficient to solve all the potential issues internally and definitely will
> cost our lots of efforts and patients.
>
>
> My check list,
>
>
> [x] Download links are valid.
> [x] Checksums and PGP signatures are valid.
> [ ] LICENSE, NOTICE and DISCLAIMER files are correct. (Need double check)
> [x] All files have license headers if necessary.
>
>
> Most of the files are fine, but it still has some bits around AgensGraph
> or bitnine.
>
>
> Run
> ```
> grep bitnine . -R -n
> grep AgensGraph  . -R -n
> ```
> It will show you, like
> ```
> ./frontend/src/components/frame/presentations/ServerStatusFrame.jsx:92:
> <p>You are currently not connected to AgensGraph</p>
> ./frontend/src/components/frame/presentations/ServerDisconnectFrame.jsx:32:
> disconnectToAgensGraph,
> ```
>
>
> Please keep in mind Apache AGE totally has nothing to do with AgensGraph
> or bitnine business currently and in the future. (Maybe AgensGraph is in
> consideration to rename?)
>
>
>
>
>
> ------------------------------------------------------------------------------
> Juan Pan(Trista), Twitter: @tristaZero
>
>
> On 02/1/2022 02:10,John Gemignani<jgemign...@apache.org> wrote:
> I will give this a +1.
>
> However, I haven't seen any traction on this thread for a while. Should
> this be closed and then reopened? Or, should we continue to try to get
> enough votes? Or?
>
> Mentors, could you please give your input?
>
> Thanks!
>
> John
>
> On 2022/01/10 04:38:32 Alex Kwak wrote:
> Sorry, All.
>
> It was a mistake to close it. We will continue voting.
>
> On 2022/01/10 02:37:21 Alex Kwak wrote:
> Hello Community,
>
> We are closing the vote. Results will be sent shortly.
>
> On 2022/01/06 02:20:46 Alex Kwak wrote:
> Dear Apache AGE Community,
>
> This is an official vote for the Apache AGE Viewer release v1.0.0-rc1 that
> we have been working toward it.
>
> To learn more about Apache AGE, please see http://age.apache.org/
>
> Functionalities included and addressed in this release:
> - Graph visualization for AGE.
> - Extends edge and vertex point by point.
>
>
> The vote is open now and until January 8th at 6:00 PM PST and passes if a
> majority +1 votes are cast, with a minimum of 3 +1 votes.
>
> [ ] +1 Release this package as Apache AGE Viewer v1.0.0
> [ ] 0 I won't get in the way
> [ ] -1 Do not release this package because ...
>
>
> The git tag to be discussed and voted upon
> https://github.com/apache/incubator-age-viewer/releases/tag/v1.0.0-rc1
>
> The git commit hash:
> commit 2b7fe6018d9da5ce10cf206cc6e879577a3d8051
>
> The release files, including signatures, digests, etc. can be found at:
>
>
> https://dist.apache.org/repos/dist/dev/incubator/age/viewer/apache-age-viewer-1.0.0-incubating-rc1/
>
> The SHA512 Checksum for these artifacts is:
>
>
> dce65e48c222d4bd0b1be8f571495b50217fcf60d82599702f3e42b36cc5afb0045b798099f981c0db13ed76a94157f9f6dadeb5940a20756bb5c2f6fb6b8009
>
> Release artifacts are signed with the following key:
> https://downloads.apache.org/incubator/age/KEYS
>
> The fingerprint of key to sign release artifacts:
> 0E7F 408D 8C6A 1952 329C B379 D471 FDCE 5F5C 5B82
>
> For more information about the contents of this release, see:
> https://github.com/apache/incubator-age-viewer/releases/tag/v1.0.0-rc1
>
>
>
> Best regards,
> Alex Kwak
>
>
>
>
>

Reply via email to