+1, especially for new features. I think we could allow direct commits for 
small bug fixes (especially time-sensitive ones) and other small changes.

On Mar 12, 2018, at 1:34 PM, DImuthu Upeksha 
<dimuthu.upeks...@gmail.com<mailto:dimuthu.upeks...@gmail.com>> wrote:

Hi Folks

For last few months most of us had to send pull requests to the Airavata 
repository and most of the pull requests were reviewed thoroughly and merged 
with the tremendous support of Marcus and other committers of the project.

As now we have a significantly active committer base, I believe we can get help 
from new committers to enforce review-commit cycle in order to improve the 
quality of code. Here is the idea.

Everyone (whether you are a committer or not) sends pull request to the project 
rather than directly committing. Then others can review the pull request and 
give their feedback. If there is nothing to change, they can simply comment +1 
to the pull request. If all the comments for the PR were resolved and there are 
at least 2 (let's discuss about this number) +1s form the committers, then the 
PR can be merged. This will enable to view our code from another eye and fix 
potential future issues right at the beginning.

Please share your ideas.

Thanks
Dimuthu

Reply via email to