Hi Dimuthu,

Please note that the PR[1] has been updated.

[1] https://github.com/apache/airavata/pull/192

Regards,

On 12 April 2018 at 22:53, Lahiru Jayathilake <lahiruj...@cse.mrt.ac.lk>
wrote:

> Hi Dimuthu,
>
> Thanks for the review. Sure I will updated them accordingly.
>
> Regards,
>
> On 12 April 2018 at 20:15, DImuthu Upeksha <dimuthu.upeks...@gmail.com>
> wrote:
>
>> Hi Lahiru,
>>
>> This is really nice and clean.
>>
>> I have added few comments in the PR though. Specially you have to
>> parameterize the values inside the template files. Have a look at an
>> existing template file. Also you can separate out job monitors into a new
>> role to have a better separation among helix components and monitors. There
>> are few more improvements that you can do but at the moment let's go with
>> this and do the changes when necessary.
>>
>> Thanks
>> Dimuthu
>>
>> On Thu, Apr 12, 2018 at 9:32 AM, Lahiru Jayathilake <
>> lahiruj...@cse.mrt.ac.lk> wrote:
>>
>>> Hi Everyone,
>>>
>>> I have made a PR[1] which includes Ansible changes required for
>>> helix-distribution.
>>>
>>> There is an Ansible role called helix_setup which is for,
>>>
>>>    - creating Helix deployment directory
>>>    - downloading & unarchiving Helix
>>>    - creating a cluster
>>>    - copying distributions to helix deployment directory.
>>>    (Distributions of
>>>    Helix Controller, Helix Participant, Pre Work flow Manager, Post
>>>    Work flow Manager, Email Monitor, & Realtime Monitor)
>>>    - copying airavata server property files, logback configuration
>>>    files, & configuration files
>>>    - stoping the daemons
>>>    - starting all the 6 daemons
>>>
>>>
>>> [1] https://github.com/apache/airavata/pull/192
>>>
>>> Thanks & Regards,
>>> --
>>> Lahiru Jayathilake
>>> Department of Computer Science and Engineering,
>>> Faculty of Engineering,
>>> University of Moratuwa
>>>
>>> <https://lk.linkedin.com/in/lahirujayathilake>
>>>
>>
>>
>
>
> --
> Lahiru Jayathilake
> Department of Computer Science and Engineering,
> Faculty of Engineering,
> University of Moratuwa
>
> <https://lk.linkedin.com/in/lahirujayathilake>
>



-- 
Lahiru Jayathilake
Department of Computer Science and Engineering,
Faculty of Engineering,
University of Moratuwa

<https://lk.linkedin.com/in/lahirujayathilake>

Reply via email to