Hi Jarek,

tested quickly on ArchLinux. Overall looks very good, thanks for all the
effort!


When building the images for the first time I saw the following warning:
```
WARNING: Error loading config file: /root/.docker/config.json: stat
/root/.docker/config.json: permission denied
```


When running `./scripts/ci/local_ci_enter_environment.sh` the first time
it fails:
```
$ PYTHON_VERSION=3.6 BACKEND=postgres ENV=docker
./scripts/ci/local_ci_enter_environment.sh
/opt/airflow/scripts/ci/in_container/entrypoint_ci.sh: line 57:
CLEAN_FILES: unbound variable
```
I added `CLEAN_FILES=false` to the command then it worked. Next time the
additional env variable was not required.


Within the dev env I was able to run test using `run-tests`.


However running flake8 or pylint fails, seems the `hooks` folder is not
mounted into the docker container:
```
/opt/airflow /opt/airflow
scripts/ci/ci_flake8.sh: line 32: ./hooks/build: No such file or directory
```


Another observation: Files and folders created by the environment have
user/group `root` (examples are `logs` and `__pycache__`). I assume the
reason is that the container runs as user root. Maybe it's possible to
run the container with uid/gid of the curren user using `-u $(id
-u):$(id -g)`?


Kind Regards,
Stefan


Reply via email to