Yep Maxime 100% agree! It's exactly what I am going to make proposal about next :) and I have working POC as well for Airflow: https://github.com/PolideaInternal/airflow/pull/97/ (and result of it in Travis: https://travis-ci.org/PolideaInternal/airflow/jobs/555443376)
On Thu, Jul 18, 2019 at 12:31 AM Maxime Beauchemin < [email protected]> wrote: > `pre-commit` is pretty great if someone wants to set it up. > https://pre-commit.com/ > > Here's what our configuration looks like for Superset: > > https://github.com/apache/incubator-superset/blob/master/.pre-commit-config.yaml > > It's super fast too as it only executes for the files that have been > touched in that commit. > > Setting up `black` is a great idea too, except for the fact that all open > PRs will conflict to some extent. > > Max > > On Wed, Jul 17, 2019 at 2:00 PM Jarek Potiuk <[email protected]> > wrote: > > > Hello everyone, > > > > Following merging AIP-10, I have a kind request to you. In order to limit > > failed checks on Travis CI (and make your development workflow faster). > You > > should be able to run all static code analysis tests very easily - and > they > > will be run consistently with Travis CI runs. > > > > You can run tests for all files or selectively for packages. > > > > You can find documentation on how to run such tests here: > > > > > https://github.com/apache/airflow/blob/master/CONTRIBUTING.md#running-static-code-analysis > > > > J. > > > > -- > > > > Jarek Potiuk > > Polidea <https://www.polidea.com/> | Principal Software Engineer > > > > M: +48 660 796 129 <+48660796129> > > [image: Polidea] <https://www.polidea.com/> > > > -- Jarek Potiuk Polidea <https://www.polidea.com/> | Principal Software Engineer M: +48 660 796 129 <+48660796129> [image: Polidea] <https://www.polidea.com/>
