I agree that many commit messages are often lacking but I'm not a fan of that the prefix style that app requires, - plus I think it would still be possible to have unhelpful PR titles just with 'fix:' prefixed.
Is rather we as commiters updated the pr subjects when reviewing. The rule I try to follow is to (mentally) prefix the message with "When this commit is applied it will ..." -a On 26 April 2020 09:34:56 BST, Tomasz Urbaszek <turbas...@apache.org> wrote: >Hi all! > >Sometimes it happens that pull requests or commits have not so >meaningful messages and it's hard to say what's exactly going on. >So I am wondering if we would like to consider using semantic pull >request: https://github.com/zeke/semantic-pull-requests > >Since we are using Github it should be pretty easy to add: >https://github.com/apps/semantic-pull-requests > >Of course, it does not solve the problem of "pr message" but >definitely it raises attention about it. On the other hand, it should >also help with publishing changelogs. Personally I like this approach >and I used to use it before joining Airflow. > >Happy to see what you think about it. And sorry if it was decided some >ago that Airflow won't follow it. > >Cheers, >Tomek
