And just for the record - lazy consensus achieved :) On Thu, Oct 8, 2020 at 2:05 PM Jarek Potiuk <[email protected]> wrote:
> Perfect! Lazy consensus continues :) > > On Thu, Oct 8, 2020 at 12:17 AM Kaxil Naik <[email protected]> wrote: > >> I like that, created a PR: https://github.com/apache/airflow/pull/11338 >> >> On Wed, Oct 7, 2020 at 11:10 PM Daniel Standish <[email protected]> >> wrote: >> >>> If i may propose a few [hopefully] clarifying amendments: >>> >>> 1. strike the "furthermore" >>> 2. strike "based on internal PMC discussion". It's unclear to me >>> exactly what this means (which is one problem) but assuming it means "this >>> policy was initially proposed in PMC deliberations", while this may be >>> interesting for historical reasons, it is not part of the policy itself, >>> and so chopping would enhance clarity. >>> >>> On Wed, Oct 7, 2020 at 8:33 AM Jarek Potiuk <[email protected]> >>> wrote: >>> >>>> Really small (I hope) thing. >>>> >>>> While cleaning up the cwiki document, one of the documents contained >>>> the Commit policy agreed in 2016. I want to bring it in CONTRIBUTORS.rst: >>>> https://github.com/apache/airflow/pull/11314 but with small >>>> modifications to reflect the reality. >>>> >>>> I hope we can reach lasy consensus >>>> <http://community.apache.org/committers/lazyConsensus.html>, so if >>>> no-one objects with 72 hours, it will become approved. >>>> >>>> >>>> Original: >>>> >>>> The following commit policy passed by a vote 8(binding FOR) to 0 >>>> against on May 27, 2016 on the dev list: >>>> >>>> * Commits need a +1 vote from a committer who is not the author >>>> * Furthermore, do not +1 or merge a PR that regresses linting (e.g. >>>> Landscape.io) or does not pass 4/6 travis tests. >>>> * When we do AIP voting, both PMC and committer's +1 is considered as >>>> binding vote based on internal PMC discussion. >>>> >>>> >>>> Change: >>>> >>>> The following commit policy passed by a vote 8(binding FOR) to 0 >>>> against on May 27, 2016 on the dev list *and slightly modified and >>>> consensus reached in October 2020:* >>>> >>>> * Commits need a +1 vote from a committer who is not the author >>>> * Furthermore, do not merge a PR that regresses linting or does not >>>> pass CI tests *(unless we have justification such as clearly transient >>>> error)*. >>>> * When we do AIP voting, both PMC and committer +1s are considered as >>>> binding vote based on internal PMC discussion. >>>> >>>> J. >>>> >>>> >>>> >>>> -- >>>> >>>> Jarek Potiuk >>>> Polidea <https://www.polidea.com/> | Principal Software Engineer >>>> >>>> M: +48 660 796 129 <+48660796129> >>>> [image: Polidea] <https://www.polidea.com/> >>>> >>>> > > -- > > Jarek Potiuk > Polidea <https://www.polidea.com/> | Principal Software Engineer > > M: +48 660 796 129 <+48660796129> > [image: Polidea] <https://www.polidea.com/> > > -- Jarek Potiuk Polidea <https://www.polidea.com/> | Principal Software Engineer M: +48 660 796 129 <+48660796129> [image: Polidea] <https://www.polidea.com/>
