Thanks Tomek! Re: version: I think it won't work until we release 1.10.13 (by definition >=1.10.13 will not install rc version until you specify it explicitly). So --no-deps` switch should be a recommended solution for now.
For the docs: I think we are moving fast with releases - and as Ash wrote some docs in dev - it needs updating still and things might get broken :). We are scrambling with the release and our bleeding edge is not as sharp (yet!). Thanks for understanding about it :) Re: the docs about verification has now been split to airflow/providers and we will need one for upgrade check (or maybe combining them into one): The right now is here for airflow and likely it is valid for the upgrade check with small modifications: https://github.com/apache/airflow/blob/master/dev/README_RELEASE_AIRFLOW.md#verify-release-candidates-by-contributors J. On Sat, Nov 21, 2020 at 12:03 PM Tomasz Urbaszek <[email protected]> wrote: > Btw. this link is no longer valid: > > > https://github.com/apache/airflow/blob/master/dev/README.md#vote-and-verify-the-apache-airflow-release-candidate > > but the v1-10-test version works: > > https://github.com/apache/airflow/blob/v1-10-test/dev/README.md#vote-and-verify-the-apache-airflow-release-candidate > > Tomek > > On Sat, Nov 21, 2020 at 11:44 AM Tomasz Urbaszek <[email protected]> > wrote: > > > > How can this package be installed in an existing Airflow environment? I > tried breeze with 1.10.12, 1.10.13 and v1-10-test (+ appending rc1 suffix) > and in each case I got: > > > > root@81b7a417ce5b:/opt/airflow# pip install apache-airflow-upgrade-check > > Collecting apache-airflow-upgrade-check > > Downloading apache_airflow_upgrade_check-1.0.0rc1-py2.py3-none-any.whl > (44 kB) > > |████████████████████████████████| 44 kB 1.2 MB/s > > Requirement already satisfied: packaging in > /usr/local/lib/python3.6/site-packages (from apache-airflow-upgrade-check) > (20.4) > > Collecting importlib-metadata~=2.0; python_version < "3.8" > > Downloading importlib_metadata-2.0.0-py2.py3-none-any.whl (31 kB) > > ERROR: Could not find a version that satisfies the requirement > apache-airflow<3,>=1.10.13 (from apache-airflow-upgrade-check) (from > versions: 1.10.9-bin, 1.8.1, 1.8.2rc1, 1.8.2, 1.9.0, 1.10.0, 1.10.1b1, > 1.10.1rc2, 1.10.1, 1.10.2b2, 1.10.2rc1, 1.10.2rc2, 1.10.2rc3, 1.10.2, > 1.10.3b1, 1.10.3b2, 1.10.3rc1, 1.10.3rc2, 1.10.3, 1.10.4b2, 1.10.4rc1, > 1.10.4rc2, 1.10.4rc3, 1.10.4rc4, 1.10.4rc5, 1.10.4, 1.10.5rc1, 1.10.5, > 1.10.6rc1, 1.10.6rc2, 1.10.6, 1.10.7rc1, 1.10.7rc2, 1.10.7rc3, 1.10.7, > 1.10.8rc1, 1.10.8, 1.10.9rc1, 1.10.9, 1.10.10rc1, 1.10.10rc2, 1.10.10rc3, > 1.10.10rc4, 1.10.10rc5, 1.10.10, 1.10.11rc1, 1.10.11rc2, 1.10.11, > 1.10.12rc1, 1.10.12rc2, 1.10.12rc3, 1.10.12rc4, 1.10.12, 1.10.13rc1, > 2.0.0b1, 2.0.0b2, 2.0.0b3) > > ERROR: No matching distribution found for apache-airflow<3,>=1.10.13 > (from apache-airflow-upgrade-check) > > > > It seems that upgrade check is trying to install airflow even when one > is installed already. I was able to install the package using --no-deps > flag, however this is not something I would recommend to users. > > > > The command works fine, it found few problems in default Airflow > configuration of 1.10.13. > > > > Btw. the right way to run it without 1.10.13rc is: > > python -c 'from airflow.upgrade.checker import __main__; __main__()' > > > > Mind the dot between upgrade and checker :) > > > > I'm -0.5 due to installation issues. > > > > Best, > > Tomek > > > > On Fri, Nov 20, 2020 at 11:28 PM Ash Berlin-Taylor <[email protected]> > wrote: > >> > >> Hey all, > >> > >> This vote is a little bit different to our usual ones. This calls for > the first release fo apache-airflow-upgrade-check -- a collection of rules > to ease the upgrade from 1.10 to 2.0.0. These checks are not final or > complete, and more can be released in future releases of this dist, and > users will be notified that there is an update available. > >> > >> This calls for the release of a new dist: apache-airflow-upgrade-check, > version 1.0.0. This represents the contents of the airflow/upgrade/ tree > (plus a few supporting files) as a separate dist, as called for in > https://github.com/apache/airflow/issues/11112 > >> > >> This email is calling a vote on the release, which will last until > 10:00 UTC on Wednesday 25th November (timed to coincide with the planned > 1.10.13rc1 vote) > >> > >> Consider this my (binding) +1. > >> > >> The files can be downloaded from > >> https://dist.apache.org/repos/dist/dev/airflow/upgrade-check/1.0.0rc1/ > >> > >> *apache-airflow-upgrade-check-1.0.0rc1-source.tar.gz* is a source > release containing the files that made up the binary and wheel releases. > >> > >> * apache-airflow-upgrade-check-1.0.0rc1-bin.tar.gz* is the binary > Python "sdist" release. > >> > >> * apache_airflow_upgrade_check-1.0.0rc1-py2.py3-none-any.whl* is the > binary Python pre-compiled wheel file. > >> > >> Public keys are available at: > >> https://dist.apache.org/repos/dist/release/airflow/KEYS > >> > >> This dist is also available PyPI > https://pypi.org/project/apache-airflow-upgrade-check/ > >> > >> Only votes from PMC members are binding, but members of the community > to test the release and vote with "(non-binding)". > >> > >> The test procedure for PMCs and Contributors who would like to test > this RC are described in > >> > https://github.com/apache/airflow/blob/master/dev/README.md#vote-and-verify-the-apache-airflow-release-candidate, > but again, this time it is a little bit different. > >> > >> To actually use this command, either wait for Kaxil to release the > 1.10.13rc1, and then run `airflow upgrade_check`, or in the mean time you > can run this with `python -c 'from airflow.upgradechecker import __main__; > __main__()'` > >> > >> Please note that the version number inside the archives exclude the > `rcX` string, so it's now simply 1.0.0. This will allow us to rename the > artifact without modifying the artifact checksums when we actually release. > >> > >> Thanks, > >> Ash > -- Jarek Potiuk Polidea <https://www.polidea.com/> | Principal Software Engineer M: +48 660 796 129 <+48660796129> [image: Polidea] <https://www.polidea.com/>
