Why not +10000 Ash :) ? On Wed, Jun 23, 2021 at 9:00 PM Andrew Godwin <andrew.god...@astronomer.io.invalid> wrote: > > I can't cast a binding vote on this, but I would also like to chime in with > support for this move. We have plenty of protection from everything else, and > while we could try to go through pylint and disable every superfluous check, > I'm not sure it's worth it. > > Andrew > > On Wed, Jun 23, 2021 at 12:49 PM Ash Berlin-Taylor <a...@apache.org> wrote: >> >> Clearly I'm +7000 on this. >> >> On 23 June 2021 19:38:13 BST, Xinbin Huang <bin.huan...@gmail.com> wrote: >>> >>> I would like to deprecate it too, so count +1 from me. One question I have >>> is: do we have any ways to detect and prevent cyclic imports? >>> >>> On Wed, Jun 23, 2021 at 11:30 AM Jarek Potiuk <ja...@potiuk.com> wrote: >>>> >>>> I think this subject has been raised a few times (last time by Ash). >>>> Finally I grew up to embrace it as well. >>>> >>>> I think I am also fed-up by random pylint errors. Last time >>>> https://github.com/apache/airflow/pull/15634/checks?check_run_id=2896761068 >>>> >>>> We have many, many pylint exceptions all over our code. I can't >>>> remember the last time where pylint prevented any real error. As Ash >>>> (rightfully) mentioned in latest discussion on slack - we have >>>> mypy/flake/isort/black which report (and fix) vast majority of things >>>> pylint reports. >>>> >>>> I think this last error was the final drop for me. >>>> >>>> Should we remove pylint ? >>>> >>>> Consider it +1 from my side. >>>> >>>> J . >>>> >>>> >>>> -- >>>> +48 660 796 129
-- +48 660 796 129
