Nice, thanks for the quick fix, Jed. I just tested the 2.3.2rc1 with your changes in the PR. It works fine.
Thanks, Ping On Tue, May 31, 2022 at 4:31 PM Jed Cunningham <[email protected]> wrote: > Thanks Ping. This was a miss in one of my optimizations. PR here, if you'd > like to test it as well: https://github.com/apache/airflow/pull/24059 > > On Tue, May 31, 2022 at 4:51 PM Ping Zhang <[email protected]> wrote: > >> It looks like the grid view is broken for me. Please see this gist for >> more info: >> https://gist.github.com/pingzh/b9abaeac2357a496d0675acde439b736 >> >> Here is a short stacktrace: >> >> File >> "/Users/ping_zhang/miniforge3/envs/apache-airflow/lib/python3.9/site-packages/airflow/www/views.py", >> line 270, in task_group_to_grid >> children = [task_group_to_grid(child, dag, dag_runs, session) for child >> in task_group.topological_sort()] >> File >> "/Users/ping_zhang/miniforge3/envs/apache-airflow/lib/python3.9/site-packages/airflow/www/views.py", >> line 270, in <listcomp> >> children = [task_group_to_grid(child, dag, dag_runs, session) for child >> in task_group.topological_sort()] >> File >> "/Users/ping_zhang/miniforge3/envs/apache-airflow/lib/python3.9/site-packages/airflow/www/views.py", >> line 261, in task_group_to_grid >> 'instances': wwwutils.get_task_summaries(task_item_or_group, dag_runs, >> session), >> File >> "/Users/ping_zhang/miniforge3/envs/apache-airflow/lib/python3.9/site-packages/airflow/www/utils.py", >> line 170, in get_task_summaries >> return [_get_summary(ti) for ti in tis] >> File >> "/Users/ping_zhang/miniforge3/envs/apache-airflow/lib/python3.9/site-packages/airflow/www/utils.py", >> line 170, in <listcomp> >> return [_get_summary(ti) for ti in tis] >> File >> "/Users/ping_zhang/miniforge3/envs/apache-airflow/lib/python3.9/site-packages/airflow/www/utils.py", >> line 151, in _get_summary >> task_instance, task_instances=get_mapped_instances(task_instance, >> session) >> File >> "/Users/ping_zhang/miniforge3/envs/apache-airflow/lib/python3.9/site-packages/airflow/www/utils.py", >> line 64, in get_mapped_instances >> TaskInstance.dag_id == task_instance.dag_id, >> AttributeError: Could not locate column in row for column 'dag_id' >> >> >> >> >> >> >> Thanks, >> >> Ping >> >> >> On Mon, May 30, 2022 at 11:13 PM Jarek Potiuk <[email protected]> wrote: >> >>> +1 (binding) - installed, run a few runs, verified a few issues, >>> verified signatures, licences, checksums. >>> >>> On Mon, May 30, 2022 at 4:29 PM Jarek Potiuk <[email protected]> wrote: >>> >>>> BTW. All Images (regular/slim for all python versions) are ready as >>>> well. >>>> >>>> J. >>>> >>>> >>>> >>>> >>>> On Mon, May 30, 2022 at 2:45 PM Ephraim Anierobi < >>>> [email protected]> wrote: >>>> >>>>> Hey fellow Airflowers, >>>>> >>>>> I have cut Airflow 2.3.2rc1. This email is calling a vote on the >>>>> release, >>>>> which will last at least 72 hours, from Monday, May 30, 2022, at 12:45 >>>>> pm UTC >>>>> until Thursday, June 2, 2022, at 12:45 pm UTC >>>>> <https://www.timeanddate.com/worldclock/fixedtime.html?msg=8&iso=20220602T1245&p1=1440>, >>>>> and until 3 binding +1 votes have been received. >>>>> >>>>> Status of testing of the release is kept in >>>>> https://github.com/apache/airflow/issues/24024 >>>>> >>>>> Consider this my (binding) +1. >>>>> >>>>> Airflow 2.3.2rc1 is available at: >>>>> https://dist.apache.org/repos/dist/dev/airflow/2.3.2rc1/ >>>>> >>>>> *apache-airflow-2.3.2-source.tar.gz* is a source release that comes >>>>> with INSTALL instructions. >>>>> *apache-airflow-2.3.2.tar.gz* is the binary Python "sdist" release. >>>>> *apache_airflow-2.3.2-py3-none-any.whl* is the binary Python wheel >>>>> "binary" release. >>>>> >>>>> Public keys are available at: >>>>> https://dist.apache.org/repos/dist/release/airflow/KEYS >>>>> >>>>> Please vote accordingly: >>>>> >>>>> [ ] +1 approve >>>>> [ ] +0 no opinion >>>>> [ ] -1 disapprove with the reason >>>>> >>>>> Only votes from PMC members are binding, but all members of the >>>>> community >>>>> are encouraged to test the release and vote with "(non-binding)". >>>>> >>>>> The test procedure for PMCs and Contributors who would like to test >>>>> this RC are described in >>>>> >>>>> https://github.com/apache/airflow/blob/main/dev/README_RELEASE_AIRFLOW.md\#verify-the-release-candidate-by-pmcs >>>>> >>>>> Please note that the version number excludes the `rcX` string, so it's >>>>> now >>>>> simply 2.3.2. This will allow us to rename the artifact without >>>>> modifying >>>>> the artifact checksums when we actually release. >>>>> >>>>> Release Notes: >>>>> https://github.com/apache/airflow/blob/2.3.2rc1/RELEASE_NOTES.rst >>>>> >>>>> Changes since 2.3.1: >>>>> >>>>> *Bugs*: >>>>> >>>>> - Icons in grid view for different DAG run types (#23970) >>>>> - Faster grid view (#23951) >>>>> - Disallow calling expand with no arguments (#23463) >>>>> - Add missing ``is_mapped`` field to Task response. (#23319) >>>>> - DagFileProcessorManager: Start a new process group only if current >>>>> process not a session leader (#23872) >>>>> - Mask sensitive values for not-yet-running TIs (#23807) >>>>> - Add cascade to ``dag_tag`` to ``dag`` foreign key (#23444) >>>>> - Use ``--subdir`` argument value for standalone dag processor. >>>>> (#23864) >>>>> - Highlight task states by hovering on legend row (#23678) >>>>> - Fix and speed up grid view (#23947) >>>>> - Prevent UI from crashing if grid task instances are null (#23939) >>>>> - Remove redundant register exit signals in ``dag-processor`` command >>>>> (#23886) >>>>> - Add ``__wrapped__`` property to ``_TaskDecorator`` (#23830) >>>>> - Fix UnboundLocalError when ``sql`` is empty list in DbApiHook >>>>> (#23816) >>>>> - Enable clicking on DAG owner in autocomplete dropdown (#23804) >>>>> - Simplify flash message for ``_airflow_moved`` tables (#23635) >>>>> - Exclude missing tasks from the gantt view (#23627) >>>>> >>>>> Cheers, >>>>> Ephraim >>>>> >>>>
