Loving Ash idea, param schema seems to have everything we need on top of making this change much easier to implement.
Pierre Le mer. 21 sept. 2022 à 12:42, Ash Berlin-Taylor <[email protected]> a écrit : > Hey Jens, > > Nice idea. I've left a comment on the AIP page, suggesting that we use the > existing DAG param typying (which is built on top of JSON schema) -- to me > it has a number of advtanges > > a) easier to secure (declarative, rather than executing code) which is a > good goal as it means it can work with the multi-tenancy AIP work going on. > b) It's a much smaller change, all we'd need is the converstion from JSON > schema to UI elements > c) It's small to the point of not even *needing* an AIP to achive > > There's a bit more detail and a few examples in my comment on the AIP. > On Sep 18 2022, at 9:52 pm, Scheffler Jens (XC-DX/ETV5) > <[email protected]> wrote: > > > Hi Airflow-Community, > > > > After raising Github issue 26215 > <https://github.com/apache/airflow/issues/26215> I received and created a > new AIP-50 > <https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-50+Trigger+DAG+UI+Extension+with+Flexible+User+Form+Concept> > I’d > like to follow-up to start a discussion via the devlist about a user form > proposal. We are actively using such kind of feature and see that probably > others also will have a demand for this. So far we have implemented such > kind of extension as an Airflow Plugin. > > > > > https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-50+Trigger+DAG+UI+Extension+with+Flexible+User+Form+Concept > > > > > > > > What we want to propose and also offer to contribute is an UI extension > such that users creating a DAG can add custom trigger forms which improve > user experience over the current option to enter a JSON dict. We know that > current parallel activity of AIP-38 is ongoing so we understand that we > don’t want to extensively elaborate on the existing UI while there are > efforts on migration ongoing. > > > > We’d love your feedback and nothing is written in stone. Also we could > offer a small PoC PR and of course also discuss alternatives and > compromises. > > > > Mit freundlichen Grüßen / Best regards > > *Jens Scheffler* > > Deterministik open Loop (XC-DX/ETV5) > Robert Bosch GmbH | Hessbruehlstraße 21 | 70565 Stuttgart-Vaihingen | > GERMANY | www.bosch.com > Tel. +49 711 811-91508 | Mobil +49 160 90417410 | Threema / Threema Work: > KKTVR3F4 | [email protected] > > Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart, HRB 14000; > Aufsichtsratsvorsitzender: Prof. Dr. Stefan Asenkerschbaumer; > Geschäftsführung: Dr. Stefan Hartung, > Dr. Christian Fischer, Filiz Albrecht, Dr. Markus Forschner, Dr. Markus > Heyn, Rolf Najork > > >
