+1 (non-binding). - Verified that running our example DAGs did not reveal any regressions. - Verified installation with helm chart and running example DAGS. - Verified the API endpoints and no regressions were found.
Regards, Rahul Vats 9953794332 On Fri, 19 Jan 2024 at 00:46, Andrey Anshin <andrey.ans...@taragol.is> wrote: > +1 binding > > Checked signatures, files, licences and also my changes > > One small nit which I've noticed when executing check_files.py. After we > switch to hatch the source distribution name include non-normalized name: > use _ (underscore) instead of - (hyphen): apache_airflow-2.8.1.tar.gz > instead of apache*-*airflow-2.8.1.tar.gz, this naming is valid according to > > https://packaging.python.org/en/latest/specifications/name-normalization/#name-normalization > < > https://packaging.python.org/en/latest/specifications/name-normalization/#name-normalization > > > > > > On Thu, 18 Jan 2024 at 15:32, rom sharon <rom.sharo...@gmail.com> wrote: > > > +1 Non binding > > > > בתאריך יום ה׳, 18 בינו׳ 2024 ב-13:31 מאת Elad Kalif < > > elad...@apache.org > > >: > > > > > +1 binding > > > > > > On Thu, Jan 18, 2024 at 12:52 PM Bolke de Bruin <bdbr...@gmail.com> > > wrote: > > > > > > > +1 binding. > > > > > > > > On Thu, 18 Jan 2024 at 11:00, Hussein Awala <huss...@awala.fr> > wrote: > > > > > > > > > +1 (binding) Checked signatures, checksums, licences and sources, I > > > also > > > > > ran some testing DAGs; all look good. > > > > > > > > > > > > > > > On Thu 18 Jan 2024 at 06:54, Phani Kumar < > phani.ku...@astronomer.io > > > > > .invalid> > > > > > wrote: > > > > > > > > > > > +1 non binding > > > > > > > > > > > > On Thu, Jan 18, 2024 at 10:30 AM Amogh Desai < > > > amoghdesai....@gmail.com > > > > > > > > > > > wrote: > > > > > > > > > > > > > +1 non binding > > > > > > > > > > > > > > Installed the RC with helm charts, tried a couple of > installation > > > > > > > configurations > > > > > > > and ran a few examples, not seeing any regression. > > > > > > > > > > > > > > Thanks & Regards, > > > > > > > Amogh Desai > > > > > > > > > > > > > > On Thu, Jan 18, 2024 at 12:16 AM Jed Cunningham < > > > > > > jedcunning...@apache.org> > > > > > > > wrote: > > > > > > > > > > > > > > > +1 (binding) > > > > > > > > > > > > > > > > Checked signatures, checksums, licences. Used it with the > helm > > > > chart > > > > > > > with a > > > > > > > > few different configs > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > -- > > > > Bolke de Bruin > > > > bdbr...@gmail.com > > > > > > > > > >
