My vote goes to #36537. But I think we should mention PR #22253 as a PR which finally merged - "keep calm and add changes"
On Tue, 23 Jan 2024 at 17:36, Wei Lee <weilee...@gmail.com> wrote: > My vote is for #36537. Love this packaging improvement! > > Best, > Wei > > > On Jan 23, 2024, at 10:30 PM, Ryan Hatter > > <ryan.hat...@astronomer.io.INVALID> > wrote: > > > > Gotta agree with Constance and go with 22253 -- how cool that the author > > stuck with it all this time! > > > > On Tue, Jan 23, 2024 at 12:25 AM Aritra Basu <aritrabasu1...@gmail.com> > > wrote: > > > >> My vote is for #36537 it's been a huge effort and it makes huge > >> improvements in our packaging. Great to see it make it into airflow. > >> > >> -- > >> Regards, > >> Aritra Basu > >> > >> On Tue, Jan 23, 2024, 10:13 AM Amogh Desai <amoghdesai....@gmail.com> > >> wrote: > >> > >>> Is there a possibility to vote for more than one? I guess not :/ > >>> > >>> My vote goes to #36537 for the enhancements that have come in with it. > I > >>> have followed the discussions > >>> at a higher level and it surely wasn't easy :) > >>> (If I could vote again, it would surely be #36537 for the endless > >>> perseverance and dedication of the author) > >>> > >>> Thanks & Regards, > >>> Amogh Desai > >>> > >>> On Tue, Jan 23, 2024 at 3:21 AM Jarek Potiuk <ja...@potiuk.com> wrote: > >>> > >>>> Heck, why not. I will shamelessly vote on my #36537. While it took > >> just a > >>>> few weeks to merge, It leapfrogged our legacy packaging setup to > >>>> more-or-less bleeding edge from what was there since the beginning of > >>>> Airflow (almost 10 years) and was already "old-ish" when I joined the > >>>> project more than 4 years ago. And with hatch and cleanups in extras, > >> it > >>>> has a positive impact on both - contributors and users (or so I hope). > >>>> > >>>> On Mon, Jan 22, 2024 at 7:48 PM Constance Martineau > >>>> <consta...@astronomer.io.invalid> wrote: > >>>> > >>>>> +1 #22253 > >>>>> > >>>>> The PR was opened in March 2022, and was finally merged last week! I > >>>> admire > >>>>> the author's persistence in getting this merged in, and think the > >>>>> simplifications to the interface make the Operator more user-friendly > >>> for > >>>>> our Data Science users. > >>>>> > >>>>> On Mon, Jan 22, 2024 at 1:29 PM Briana Okyere > >>>>> <briana.oky...@astronomer.io.invalid> wrote: > >>>>> > >>>>>> Hey All, > >>>>>> > >>>>>> It’s once again time to vote for the PR of the Month. > >>>>>> > >>>>>> With the help of the `get_important_pr_candidates` script in > >>> dev/stats, > >>>>>> we've identified the following candidates: > >>>>>> > >>>>>> PR #36513: Include plugins in the architecture diagrams. > >>>>>> <https://github.com/apache/airflow/pull/36513> > >>>>>> > >>>>>> PR #32867: Sanitize the conn_id to disallow potential script > >>>> execution. < > >>>>>> https://github.com/apache/airflow/pull/32867> > >>>>>> > >>>>>> PR #22253: Add SparkKubernetesOperator crd implementation. > >>>>>> <https://github.com/apache/airflow/pull/22253> > >>>>>> > >>>>>> PR #36171: Implement AthenaSQLHook. > >>>>>> <https://github.com/apache/airflow/pull/36171> > >>>>>> > >>>>>> PR #36537: Standardize airflow build process and switch to > >> Hatchling > >>>>> build > >>>>>> backend. <https://github.com/apache/airflow/pull/36537> > >>>>>> > >>>>>> Please reply to this thread with your selection or offer your own > >>>>>> nominee(s). > >>>>>> > >>>>>> Voting will close on Jan. 26th at 1 PM PST. The winner(s) will be > >>>>> featured > >>>>>> in the next issue of the Airflow newsletter. > >>>>>> > >>>>>> Also, if there’s an article or event that you think should be > >>> included > >>>> in > >>>>>> this or a future issue of the newsletter, please drop me a line at > >> < > >>>>>> briana.oky...@astronomer.io>. > >>>>>> > >>>>>> -- > >>>>>> Briana Okyere > >>>>>> Community Manager > >>>>>> *Astronomer* > >>>>>> > >>>>> > >>>>> > >>>>> -- > >>>>> > >>>>> Constance Martineau > >>>>> Senior Product Manager > >>>>> > >>>>> Email: consta...@astronomer.io > >>>>> Time zone: US Eastern (EST UTC-5 / EDT UTC-4) > >>>>> > >>>>> > >>>>> <https://www.astronomer.io/> > >>>>> > >>>> > >>> > >> > >
