+1 (non-binding) Ran a few example DAGs and worked fine. Best, Wei
> On Mar 25, 2024, at 3:30 PM, Amogh Desai <amoghdesai....@gmail.com> wrote: > > +1 non binding > > Verified my changes, and ran a few example DAGs. I see no regressions. > > Thanks & Regards, > Amogh Desai > > > On Sat, Mar 23, 2024 at 8:11 PM Andrey Anshin <andrey.ans...@taragol.is> > wrote: > >> +1 binding >> >> Checked files, licences, signatures and also my changes. >> >> One small nit that I've found is that the key which is used for sign >> releases is expired, I'm not sure if it should be considered as a >> showstopper. >> >> ❯ gpg --verify apache_airflow-2.8.4-py3-none-any.whl.asc >> apache_airflow-2.8.4-py3-none-any.whl >> gpg: Signature made Wed Mar 20 19:17:26 2024 +04 >> gpg: using RSA key E1A1E984F55B8F280BD9CBA20BB7163892A2E48E >> gpg: issuer "jedcunning...@apache.org" >> gpg: Good signature from "Jed Cunningham <jedcunning...@apache.org>" >> [ultimate] >> gpg: Note: This key has expired! >> Primary key fingerprint: A020 DD36 34F1 A4D1 26A1 C554 7774 A4E5 90CB 0351 >> Subkey fingerprint: E1A1 E984 F55B 8F28 0BD9 CBA2 0BB7 1638 92A2 E48E >> >> ❯ gpg --list-options show-unusable-subkeys --list-keys >> A020DD3634F1A4D126A1C5547774A4E590CB0351 >> pub rsa4096 2022-01-05 [C] >> A020DD3634F1A4D126A1C5547774A4E590CB0351 >> uid [ultimate] Jed Cunningham <jedcunning...@apache.org> >> sub rsa4096 2022-01-05 [A] [expired: 2024-01-05] >> sub rsa4096 2022-01-05 [E] [expired: 2024-01-05] >> sub rsa4096 2022-01-05 [S] [expired: 2024-01-05] >> >> >> >> >> On Fri, 22 Mar 2024 at 15:24, Rahul Vats <rah.sharm...@gmail.com> wrote: >> >>> +1 (non-binding) >>> >>> Verified running our regression DAGS and API tests. LGTM >>> >>> Regards, >>> Rahul Vats >>> 9953794332 >>> >>> >>> On Fri, 22 Mar 2024 at 15:24, Hussein Awala <huss...@awala.fr> wrote: >>> >>>> +1 (binding) checked licences, checksums, signatures, and source codes, >>> and >>>> ran some testing dags. All looks good. >>>> >>>> On Wed, Mar 20, 2024 at 7:54 PM Jarek Potiuk <ja...@potiuk.com> wrote: >>>> >>>>> +1 (binding) - tested / verified all changes I was involved (either >> as >>>>> fixer, bug introducer or both, particularly when both), verified >>>>> reproducibility, licences, checksums, signatures, run a few DAGs - >> all >>>>> looks good. >>>>> >>>>> On Wed, Mar 20, 2024 at 4:56 PM Jed Cunningham < >>> jedcunning...@apache.org >>>>> >>>>> wrote: >>>>> >>>>>> Hey fellow Airflowers, >>>>>> >>>>>> I have cut Airflow 2.8.4rc1. This email is calling a vote on the >>>> release, >>>>>> which will last at least 72 hours, from Wednesday, March 20, 2024 >> at >>>> 4:00 >>>>>> pm UTC >>>>>> until Saturday, March 23, 2024 at 4:00 pm UTC, and until 3 binding >> +1 >>>>> votes >>>>>> have been received. >>>>>> >>>>>> >>>>>> >>>>> >>>> >>> >> https://www.timeanddate.com/worldclock/fixedtime.html/?msg=8&iso=20240323T1600&p1=1440 >>>>>> >>>>>> Status of testing of the release is kept in >>>>>> https://github.com/apache/airflow/issues/38334 >>>>>> >>>>>> Consider this my (binding) +1. >>>>>> >>>>>> Airflow 2.8.4rc1 is available at: >>>>>> https://dist.apache.org/repos/dist/dev/airflow/2.8.4rc1/ >>>>>> >>>>>> *apache-airflow-2.8.4-source.tar.gz* is a source release that comes >>>> with >>>>>> INSTALL instructions. >>>>>> *apache-airflow-2.8.4.tar.gz* is the binary Python "sdist" release. >>>>>> *apache_airflow-2.8.4-py3-none-any.whl* is the binary Python wheel >>>>> "binary" >>>>>> release. >>>>>> >>>>>> Public keys are available at: >>>>>> https://dist.apache.org/repos/dist/release/airflow/KEYS >>>>>> >>>>>> Please vote accordingly: >>>>>> >>>>>> [ ] +1 approve >>>>>> [ ] +0 no opinion >>>>>> [ ] -1 disapprove with the reason >>>>>> >>>>>> Only votes from PMC members are binding, but all members of the >>>> community >>>>>> are encouraged to test the release and vote with "(non-binding)". >>>>>> >>>>>> The test procedure for PMC members is described in: >>>>>> >>>>>> >>>>> >>>> >>> >> https://github.com/apache/airflow/blob/main/dev/README_RELEASE_AIRFLOW.md#verify-the-release-candidate-by-pmc-members >>>>>> >>>>>> The test procedure for and Contributors who would like to test this >>> RC >>>> is >>>>>> described in: >>>>>> >>>>>> >>>>> >>>> >>> >> https://github.com/apache/airflow/blob/main/dev/README_RELEASE_AIRFLOW.md#verify-the-release-candidate-by-contributors >>>>>> >>>>>> >>>>>> Please note that the version number excludes the `rcX` string, so >>> it's >>>>> now >>>>>> simply 2.8.4. This will allow us to rename the artifact without >>>> modifying >>>>>> the artifact checksums when we actually release. >>>>>> >>>>>> Release Notes: >>>>>> https://github.com/apache/airflow/blob/2.8.4rc1/RELEASE_NOTES.rst >>>>>> >>>>>> For information on what goes into a release please see: >>>>>> >>>>>> >>>>> >>>> >>> >> https://github.com/apache/airflow/blob/main/dev/WHAT_GOES_INTO_THE_NEXT_RELEASE.md >>>>>> >>>>>> Changes since 2.8.3: >>>>>> *Bugs*: >>>>>> - Fix incorrect serialization of ``FixedTimezone`` (#38139) >>>>>> - Fix excessive permission changing for log task handler (#38164) >>>>>> - Fix task instances list link (#38096) >>>>>> - Fix a bug where scheduler heartrate parameter was not used >> (#37992) >>>>>> - Add padding to prevent grid horizontal scroll overlapping tasks >>>>> (#37942) >>>>>> - Fix hash caching in ``ObjectStoragePath`` (#37769) >>>>>> >>>>>> *Miscellaneous*: >>>>>> - Limit importlib_resources as it breaks ``pytest_rewrites`` >> (#38095, >>>>>> #38139) >>>>>> - Limit ``pandas`` to ``<2.2`` (#37748) >>>>>> - Bump ``croniter`` to fix an issue with 29 Feb cron expressions >>>> (#38198) >>>>>> >>>>>> *Doc-only Change*: >>>>>> - Tell users what to do if their scanners find issues in the image >>>>> (#37652) >>>>>> - Add a section about debugging in Docker Compose with PyCharm >>> (#37940) >>>>>> - Update deferrable docs to clarify kwargs when trigger resumes >>>> operator >>>>>> (#38122) >>>>>> >>>>>> Thanks, >>>>>> Jed >>>>>> >>>>> >>>> >>> >>
