On Wed, Jul 3, 2024 at 9:07 PM Jarek Potiuk <ja...@potiuk.com> wrote:
> Here is the content of that JIRA ticket. > > > bharathpalaksha commented on pull request #6310: AIRFLOW-5621 > <https://issues.apache.org/jira/browse/AIRFLOW-5621> - Failure callback > is not triggered when marked Failed on UI > URL: https://github.com/apache/airflow/pull/6310 > > Make sure you have checked *all* steps below. > > 1. > 1. > 1. Jira > > > - [ ] My PR addresses the following [Airflow Jira]( > https://issues.apache.org/jira/browse/AIRFLOW-5621/) issues and > references them in the PR title. > > > 1. > 1. > 1. Description > > > - [ ] When a task is marked 'Failed' on UI, on_failure_callback on the > task is not triggered. > > > 1. > 1. > 1. Tests > > > - [ ] My PR adds the following unit tests > test_mark_failure_on_failure_callback > > > 1. > 1. > 1. Commits > > > - [ ] My commits all reference Jira issues in their subject lines, and > I have squashed multiple commits if they address the same issue. In > addition, my commits follow the guidelines from "[How to write a good > git commit message](http://chris.beams.io/posts/git-commit/)": > 1. Subject is separated from body by a blank line > 1. Subject is limited to 50 characters (not including Jira issue > reference) > 1. Subject does not end with a period > 1. Subject uses the imperative mood ("add", not "adding") > 1. Body wraps at 72 characters > 1. Body explains "what" and "why", not "how" > > ---------------------------------------------------------------- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > Edit > <https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13261248&commentId=16949600> > Delete > <https://issues.apache.org/jira/secure/DeleteComment!default.jspa?id=13261248&commentId=16949600> > [image: githubbot]ASF GitHub Bot > <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=githubbot> added > a comment - 15/Oct/19 13:04 > <https://issues.apache.org/jira/browse/AIRFLOW-5621?focusedCommentId=16951829&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16951829> > > bharathpalaksha commented on pull request #6310: AIRFLOW-5621 > <https://issues.apache.org/jira/browse/AIRFLOW-5621> - Failure callback > is not triggered when marked Failed on UI > URL: https://github.com/apache/airflow/pull/6310 > > ---------------------------------------------------------------- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > Edit > <https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13261248&commentId=16951829> > Delete > <https://issues.apache.org/jira/secure/DeleteComment!default.jspa?id=13261248&commentId=16951829> > [image: githubbot]ASF GitHub Bot > <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=githubbot> added > a comment - 15/Oct/19 13:06 > <https://issues.apache.org/jira/browse/AIRFLOW-5621?focusedCommentId=16951830&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16951830> > > bharathpalaksha commented on pull request #6335: AIRFLOW-5621 > <https://issues.apache.org/jira/browse/AIRFLOW-5621> - Failure callback > is not triggered when marked Failed on UI > URL: https://github.com/apache/airflow/pull/6335 > > Make sure you have checked all steps below. > > Jira > My PR addresses the following Airflow Jira issues and references them in > the PR title. > Description > When a task is marked 'Failed' on UI, on_failure_callback on the task is > not triggered. > Tests > My PR adds the following unit tests > test_mark_failure_on_failure_callback > Commits > My commits all reference Jira issues in their subject lines, and I have > squashed multiple commits if they address the same issue. In addition, my > commits follow the guidelines from "How to write a good git commit message": > Subject is separated from body by a blank line > Subject is limited to 50 characters (not including Jira issue reference) > Subject does not end with a period > Subject uses the imperative mood ("add", not "adding") > Body wraps at 72 characters > Body explains "what" and "why", not "how" > > ---------------------------------------------------------------- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > Edit > <https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13261248&commentId=16951830> > Delete > <https://issues.apache.org/jira/secure/DeleteComment!default.jspa?id=13261248&commentId=16951830> > [image: githubbot]ASF GitHub Bot > <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=githubbot> added > a comment - 03/Jan/20 10:22 > <https://issues.apache.org/jira/browse/AIRFLOW-5621?focusedCommentId=17007345&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17007345> > > bharathpalaksha commented on pull request #6335: AIRFLOW-5621 > <https://issues.apache.org/jira/browse/AIRFLOW-5621> - Failure callback > is not triggered when marked Failed on UI > URL: https://github.com/apache/airflow/pull/6335 > > ---------------------------------------------------------------- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > Edit > <https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13261248&commentId=17007345> > Delete > <https://issues.apache.org/jira/secure/DeleteComment!default.jspa?id=13261248&commentId=17007345> > [image: githubbot]ASF GitHub Bot > <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=githubbot> added > a comment - 03/Jan/20 10:23 > <https://issues.apache.org/jira/browse/AIRFLOW-5621?focusedCommentId=17007349&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17007349> > > bharathpalaksha commented on pull request #7017: AIRFLOW-5621 > <https://issues.apache.org/jira/browse/AIRFLOW-5621> - Failure callback > is not triggered when marked Failed… > URL: https://github.com/apache/airflow/pull/7017 > > Make sure you have checked *all* steps below. > > 1. > 1. > 1. Jira > > > - [x] My PR addresses the following [Airflow Jira]( > https://issues.apache.org/jira/browse/AIRFLOW-5621/) issues and > references them in the PR title. > > > 1. > 1. > 1. Description > > > - [x] When a task is marked 'Failed' on UI, on_failure_callback on the > task is not triggered. > > > 1. > 1. > 1. Tests > > > - [x] My PR adds the following unit tests > test_mark_failure_on_failure_callback > > > 1. > 1. > 1. Commits > > > - [ ] My commits all reference Jira issues in their subject lines, and > I have squashed multiple commits if they address the same issue. In > addition, my commits follow the guidelines from "[How to write a good > git commit message](http://chris.beams.io/posts/git-commit/)": > 1. Subject is separated from body by a blank line > 1. Subject is limited to 50 characters (not including Jira issue > reference) > 1. Subject does not end with a period > 1. Subject uses the imperative mood ("add", not "adding") > 1. Body wraps at 72 characters > 1. Body explains "what" and "why", not "how" > > ---------------------------------------------------------------- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > Edit > <https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13261248&commentId=17007349> > Delete > <https://issues.apache.org/jira/secure/DeleteComment!default.jspa?id=13261248&commentId=17007349> > [image: githubbot]ASF GitHub Bot > <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=githubbot> added > a comment - 03/Jan/20 19:48 > <https://issues.apache.org/jira/browse/AIRFLOW-5621?focusedCommentId=17007691&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17007691> > > bharathpalaksha commented on pull request #7025: AIRFLOW-5621 > <https://issues.apache.org/jira/browse/AIRFLOW-5621> - Failure callback > is not triggered when marked Failed on UI > URL: https://github.com/apache/airflow/pull/7025 > > Make sure you have checked *all* steps below. > > 1. > 1. > 1. Jira > > > - [x] My PR addresses the following [Airflow Jira]( > https://issues.apache.org/jira/browse/AIRFLOW-5621/) issues and > references them in the PR title. > > > 1. > 1. > 1. Description > > > - [x] When a task is marked 'Failed' on UI, on_failure_callback on the > task is not triggered. > > > 1. > 1. > 1. Tests > > > - [x] My PR adds the following unit tests > test_mark_failure_on_failure_callback > > > 1. > 1. > 1. Commits > > > - [ ] My commits all reference Jira issues in their subject lines, and > I have squashed multiple commits if they address the same issue. In > addition, my commits follow the guidelines from "[How to write a good > git commit message](http://chris.beams.io/posts/git-commit/)": > 1. Subject is separated from body by a blank line > 1. Subject is limited to 50 characters (not including Jira issue > reference) > 1. Subject does not end with a period > 1. Subject uses the imperative mood ("add", not "adding") > 1. Body wraps at 72 characters > 1. Body explains "what" and "why", not "how" > > ---------------------------------------------------------------- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > Edit > <https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13261248&commentId=17007691> > Delete > <https://issues.apache.org/jira/secure/DeleteComment!default.jspa?id=13261248&commentId=17007691> > [image: githubbot]ASF GitHub Bot > <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=githubbot> added > a comment - 03/Jan/20 19:49 > <https://issues.apache.org/jira/browse/AIRFLOW-5621?focusedCommentId=17007692&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17007692> > > bharathpalaksha commented on pull request #7017: AIRFLOW-5621 > <https://issues.apache.org/jira/browse/AIRFLOW-5621> - Failure callback > is not triggered when marked Failed… > URL: https://github.com/apache/airflow/pull/7017 > > ---------------------------------------------------------------- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > Edit > <https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13261248&commentId=17007692> > Delete > <https://issues.apache.org/jira/secure/DeleteComment!default.jspa?id=13261248&commentId=17007692> > [image: githubbot]ASF GitHub Bot > <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=githubbot> added > a comment - 06/Jan/20 12:26 > <https://issues.apache.org/jira/browse/AIRFLOW-5621?focusedCommentId=17008742&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17008742> > > potiuk commented on pull request #7025: AIRFLOW-5621 > <https://issues.apache.org/jira/browse/AIRFLOW-5621> - Failure callback > is not triggered when marked Failed on UI > URL: https://github.com/apache/airflow/pull/7025 > > ---------------------------------------------------------------- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > Edit > <https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13261248&commentId=17008742> > Delete > <https://issues.apache.org/jira/secure/DeleteComment!default.jspa?id=13261248&commentId=17008742> > [image: jira-bot]ASF subversion and git services > <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=jira-bot> added > a comment - 06/Jan/20 12:27 > <https://issues.apache.org/jira/browse/AIRFLOW-5621?focusedCommentId=17008743&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17008743> > > Commit 24fa9380cf28b2844951f60a7037743c6395f0a3 in airflow's branch > refs/heads/master from Bharath Palaksha > [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=24fa938 ] > > AIRFLOW-5621 <https://issues.apache.org/jira/browse/AIRFLOW-5621> - > Failure callback is not triggered when marked Failed on UI (#7025) > > On Wed, Jul 3, 2024 at 9:06 PM Alex Shafer > <alex.sha...@mindbodyonline.com.invalid> wrote: > >> Hello, >> >> I'm working on a major upgrade of our Airflow installation, and I noticed >> there is a broken link on the 1.10.8 release notes which may potentially >> contain information that I need. >> >> >> https://airflow.apache.org/docs/apache-airflow/2.4.0/release_notes.html#airflow-1-10-8-2020-02-07 >> Failure callback will be called when task is marked failed >> When task is marked failed by user or task fails due to system failures - >> on failure call back will be called as part of clean up >> See AIRFLOW-5621<https://jira.apache.org/jira/browse/AIRFLOW-5621> for >> details >> >> The jira link fails with a permissions error, and contains a link to a >> self-service signup page, which, upon selecting Airflow from the drop-down, >> then directs me to email this address. >> >> Any help with accessing details for this change would be much appreciated. >> >> Thanks, >> Alex >> >> >> >>
