+1 non binding. Tested my changes, and ran a couple of tests as well. It looks good
Thanks & Regards, Amogh Desai On Mon, Jul 15, 2024 at 2:22 PM Jarek Potiuk <ja...@potiuk.com> wrote: > +1 (binding): Checked reproducibility, signatures, checksums, licences, run > a few test cases, checked all the "tooling" upgrades that are properly > applied. All good. > > I found an issue with latest FAB provider that it had check for <= 2.9.2 > for CSRF protection on logout, but we have not cherry-picked the fix ( > https://github.com/apache/airflow/pull/40145) as it was marked as 2.10.0. > to 2.9.3, but we will fix it in the next version of FAB provider by > https://github.com/apache/airflow/pull/40784 (unless there will be reason > for rc2, in which case we might attempt to cherry-pick the #40784 to rc2). > Not critical however so I don't think it should block 2.9.3 rc1 on its own. > > On Fri, Jul 12, 2024 at 7:07 PM Utkarsh Sharma > <utkarsh.sha...@astronomer.io.invalid> wrote: > > > Hey fellow Airflowers, > > > > I have cut Airflow 2.9.3rc1. This email is calling for a vote on the > > release, > > which will last at least 72 hours, from Friday, July 12, 2024 at 5:10 pm > > UTC > > until Monday, July 15, 2024, at 5:10 pm UTC > > < > > > https://www.timeanddate.com/worldclock/fixedtime.html?msg=8&iso=20240715T1710&p1=1440 > > >, > > and until 3 binding +1 votes have been received. > > > > Status of testing of the release is kept in > > https://github.com/apache/airflow/issues/40756 > > > > Consider this my (non-binding) +1. As I’m not a member of the PMC, > Ephraim > > signed the distribution. > > > > Airflow 2.9.3rc1 is available at: > > https://dist.apache.org/repos/dist/dev/airflow/2.9.3rc1/ > > > > *apache-airflow-2.9.3-source.tar.gz* is a source release that comes with > > INSTALL instructions. > > *apache-airflow-2.9.3.tar.gz* is the binary Python "sdist" release. > > *apache_airflow-2.9.3-py3-none-any.whl* is the binary Python wheel > "binary" > > release. > > > > Public keys are available at: > > https://dist.apache.org/repos/dist/release/airflow/KEYS > > > > Please vote accordingly: > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > > Only votes from PMC members are binding, but all members of the community > > are encouraged to test the release and vote with "(non-binding)". > > > > The test procedure for PMC members is described in: > > > > > https://github.com/apache/airflow/blob/main/dev/README_RELEASE_AIRFLOW.md\#verify-the-release-candidate-by-pmc-members > > > > The test procedure for contributors and members of the community who > would > > like to test this RC is described in: > > > > > https://github.com/apache/airflow/blob/main/dev/README_RELEASE_AIRFLOW.md\#verify-the-release-candidate-by-contributors > > > > > > Please note that the version number excludes the `rcX` string, so it's > now > > simply 2.9.3. This will allow us to rename the artifact without modifying > > the artifact checksums when we actually release. > > > > Release Notes: > > https://github.com/apache/airflow/blob/2.9.3rc1/RELEASE_NOTES.rst > > > > For information on what goes into a release please see: > > > > > https://github.com/apache/airflow/blob/main/dev/WHAT_GOES_INTO_THE_NEXT_RELEASE.md > > > > *Changes since 2.9.2:* > > > > *Significant Changes* > > > > *Time unit for ``scheduled_duration`` and ``queued_duration`` changed > > (#37936)* > > > > ``scheduled_duration`` and ``queued_duration`` metrics are now emitted in > > milliseconds instead of seconds. > > > > By convention all statsd metrics should be emitted in milliseconds, this > is > > later expected in e.g. ``prometheus`` statsd-exporter. > > > > > > *Support for OpenTelemetry Metrics is no longer "Experimental" (#40286)* > > > > Experimental support for OpenTelemetry was added in 2.7.0 since then > fixes > > and improvements were added and now we announce the feature as stable. > > > > > > *Bug Fixes* > > > > - Fix calendar view scroll (#40458) > > - Validating provider description for urls in provider list view (#40475) > > - Fix compatibility with old MySQL 8.0 (#40314) > > - Fix dag (un)pausing won't work on environment where dag files are > missing > > (#40345) > > - Extra being passed to SQLalchemy (#40391) > > - Handle unsupported operand int + str when value of tag is int (job_id) > > (#40407) > > - Fix TriggeredDagRunOperator triggered link (#40336) > > - Add ``[webserver]update_fab_perms`` to deprecated configs (#40317) > > - Swap dag run link from legacy graph to grid with graph tab (#40241) > > - Change ``httpx`` to ``requests`` in ``file_task_handler`` (#39799) > > - Fix import future annotations in venv jinja template (#40208) > > - Ensures DAG params order regardless of backend (#40156) > > - Use a join for TI notes in TI batch API endpoint (#40028) > > - Improve trigger UI for string array format validation (#39993) > > - Disable jinja2 rendering for doc_md (#40522) > > - Skip checking sub dags list if taskinstance state is skipped (#40578) > > - Recognize quotes when parsing urls in logs (#40508) > > > > *Doc Only Changes* > > > > - Add notes about passing secrets via environment variables (#40519) > > - Revamp some confusing log messages (#40334) > > - Add more precise description of masking sensitive field names (#40512) > > - Add slightly more detailed guidance about upgrading to the docs > (#40227) > > - Metrics allow_list complete example (#40120) > > - Add warning to deprecated api docs that access control isn't applied > > (#40129) > > - Simpler command to check local scheduler is alive (#40074) > > - Add a note and an example clarifying the usage of DAG-level params > > (#40541) > > - Fix highlight of example code in dags.rst (#40114) > > - Add warning about the PostgresOperator being deprecated (#40662) > > - Updating airflow download links to CDN based links (#40618) > > - Fix import statement for DatasetOrTimetable example (#40601) > > - Further clarify triage process (#40536) > > - Fix param order in PythonOperator docstring (#40122) > > - Update serializers.rst to mention that bytes are not supported (#40597) > > > > *Miscellaneous* > > > > - Upgrade build installers and dependencies (#40177) > > - Bump braces from 3.0.2 to 3.0.3 in /airflow/www (#40180) > > - Upgrade to another version of trove-classifier (new CUDA classifiers) > > (#40564) > > - Rename "try_number" increments that are unrelated to the airflow > concept > > (#39317) > > - Update trove classifiers to the latest version as build dependency > > (#40542) > > - Upgrade to latest version of hatchling as build dependency (#40387) > > - Fix bug in ``SchedulerJobRunner._process_executor_events`` (#40563) > > - Remove logging for "blocked" events (#40446) > > > > > > Cheers, > > Utkarsh Sharma > > >
