+1 for 41916 given that it was their first time contribution and I would like to encourage them to continue contributing.
On Wed, 27 Nov 2024 at 13:52, Phani Kumar <phani.ku...@astronomer.io.invalid> wrote: > +1 for https://github.com/apache/airflow/pull/43902 > > I'd like to nominate PR #43502 as it was a monumental effort *(329 files)*, > both in terms of its scope and the challenges it addressed. > Resolving the CI conflicts alone required significant persistence and > multiple days of effort. > I believe it deserves recognition. > > On Wed, Nov 27, 2024 at 7:03 PM Jarek Potiuk <ja...@potiuk.com> wrote: > > > +1 on #41916 as well. > > > > > > On Wed, Nov 27, 2024 at 2:16 PM Amogh Desai <amoghdesai....@gmail.com> > > wrote: > > > > > +1 for https://github.com/apache/airflow/pull/41916 too. > > > > > > It is nice how a "first" time contributor has collaborated with the > > > maintainers > > > and managed to solve many issues and merge it. > > > > > > Kudos to https://github.com/Illumaria irrespective of the result! > > > > > > Thanks & Regards, > > > Amogh Desai > > > > > > > > > On Wed, Nov 27, 2024 at 12:18 AM Elad Kalif <elad...@apache.org> > wrote: > > > > > > > I vote for Add support for semicolon stripping to DbApiHook, > > PrestoHook, > > > > and TrinoHook > > > > https://github.com/apache/airflow/pull/41916 > > > > > > > > What started as a small scoped PR turned to be a masive one. > Including > > at > > > > least 3 edge cases discoved with our CI. Noting that the author is > > first > > > > time contribuor who did not drop it though it took weeks with > countless > > > > rebases and review rounds. > > > > > > > > I think this is a great example of valued member of the community > that > > we > > > > should recignize. > > > > > > > > בתאריך יום ג׳, 26 בנוב׳ 2024, 20:27, מאת Briana Okyere > > > > <briana.oky...@astronomer.io.invalid>: > > > > > > > > > Hey All, > > > > > > > > > > It’s once again time to vote for the PR of the Month! > > > > > > > > > > With the help of the `get_important_pr_candidates` script in > > dev/stats, > > > > > we've identified the following candidates: > > > > > > > > > > PR #43367: Add Trigger DAG UI with advance options < > > > > > https://github.com/apache/airflow/pull/43367> > > > > > > > > > > PR #41325: Add "@asset" to decorate a function as a DAG and an > asset > > < > > > > > https://github.com/apache/airflow/pull/41325> > > > > > > > > > > PR #43893: Start building the replacement task runner for Task > > > Execution > > > > > SDK <https://github.com/apache/airflow/pull/43893> > > > > > > > > > > PR #42404: Remove logical_date from DAG Run APIs and Functions, > > > > transition > > > > > to run_id as sole identifier for Airflow< > > > > > https://github.com/apache/airflow/pull/42404> > > > > > > > > > > PR #43902: Rename execution_date to logical_date across codebase < > > > > > https://github.com/apache/airflow/pull/43902> > > > > > > > > > > Please reply to this thread with your selection or offer your own > > > > > nominee(s). > > > > > > > > > > Voting will close on Friday, Nov. 29th at 5 PM PST. The winner(s) > > will > > > be > > > > > featured in the next issue of the Airflow newsletter. > > > > > > > > > > Also, if there’s an article or event that you think should be > > included > > > in > > > > > this or a future issue of the newsletter, please drop me a line at > < > > > > > briana.oky...@astronomer.io> > > > > > > > > > > -- > > > > > Briana Okyere > > > > > Community Manager > > > > > Astronomer > > > > > > > > > > > > > > >
