This is awesome Wei. I have reviewed mine and added a comment. On Wed, 15 Jan 2025 at 17:28, Wei Lee <weilee...@gmail.com> wrote:
> ## Why > Since https://github.com/apache/airflow/pull/44378, we have introduced a > newsfragments template to track our breaking changes. However, this > template was implemented after many of our earlier breaking changes, which > means that most existing news fragments do not conform to this format. By > updating these entries to match the template, we can create a script that > summarizes the breaking changes made in Airflow 3.0. This will also reduce > the manual effort required to keep the wiki page > https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+3+breaking+changes > < > https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+3+breaking+changes> > up to date. > > ## What > I created an issue https://github.com/apache/airflow/issues/45673 to > track the updating process and a pull request > https://github.com/apache/airflow/pull/45678 to add types I think it > should be and the migration rules we add or plan to add. (Most of the > migration rules have been merged into airflow or ruff already 🙌) > As I might wrongly categorize the type of change, add the wrong rules, or > miss some rules, **it would be awesome if everyone that has made any > breaking changes could take a quick look** > > ## Action items > Here's what you can do if your breaking changes already have newsfragments > with them > Check https://github.com/apache/airflow/pull/45678 and navigate to the > news fragment you created (in my case, > `newsfragments/42023.significant.rst`) to verify if my changes are correct. > If they are not, please leave a comment, and I will update you accordingly. > If everything looks good for your news fragments, please approve the pull > request (you don’t have to be a committer to approve a PR!) with a message > detailing which newsfragments you have checked (e.g., "I've checked news > fragments 42023, 42054, and everything looks good.”) > > If your breaking changes do not yet have a newsfragment, please create a > PR to add one and let me know if migration rules are needed. > > It would also be helpful if you're willing to check others' newsfragment > even if you didn't introduce the breaking changes. > > Also, you’re more than welcome to create a new PR and update your > newsfragment on your own. I’ll rebase from your branch after merging. > > Thanks! > Wei
