Hello, The caplog vote triggered me to launch this proposal as it's also related to unit testing, and as I think we want our unit tests as clean and as simple and as fast as possible.
I think it would be a good practise to not define and create real Airflow connections within the providers unit tests (which use the Airflow test database), as normally when writing unit tests those should be isolated and not be depend on any external systems like a database. Also in my case those make the tests to run slower. Beside that I 've also noticed when working on some PR regarding providers, sometimes there are some glitches within the CI/CD which seem to cause issues with those "real" connections, causing tests to randomly fail. Hence that's why when I do refactorings in provider unit tests, I've already replaced those real connections with mocked ones making tests run faster locally (no database needed) and no more random failures during tests (possibly preceding tests that mess up connections). That's doesn't mean we don't want to use the database of course during tests, I'm just saying it's a bit of overkill to use a database in a unit test just to get a connection. We could also create a common mocking method for connections in tests_common and use it across all unit tests, now those are mostly redefined across different provider tests. Of course I'm willing to contribute on this one, what do you think about this idea? Personally, I think this can only make maintenance easier (and prevent random failures and faster tests results). Curious of your thoughts. Kind regards, David [cid:image001.png@01DB793A.EE1A32C0] David Blain Data Engineer at ICT-514 - BI End User Reporting
