Just want to make sure. Should we merge our own backport PR when it’s ready? I feel a bit uncomfortable merging it, as it’s technically my code. I still requested others to review it again in the past few occurrences.
Best, Wei > On Aug 4, 2025, at 2:03 PM, Amogh Desai <amoghde...@apache.org> wrote: > > Yeah, it's easy to ignore messages from the cherry picker sometimes > assuming that adding PRs to the release milestone is good enough, but > more often than not the PR authors should ensure that their PRs land in the > right set of branches to avoid any surprises. > > Thanks & Regards, > Amogh Desai > > > On Sun, Aug 3, 2025 at 5:58 PM Jarek Potiuk <ja...@potiuk.com> wrote: > >> Hello here, >> >> I think we (including myself) dropped the ball a bit when cherry-picking >> some of the last weeks PR - resulting in unnecessary release managers >> (Ash's) work when he had to fix some issues in v3-0-stable and I had to >> also make the `v3-0-test` green to generate constraints. >> >> I think there are a few things we should pay attention to that are >> relatively quickly merging cherry-picker's PR when they get green (or >> manually doing it if they cannot be done due to conflicts). I think (not >> sure) it's mostly on the commiter who merges PRs - they should see the >> follow-up comments from the "cherry-picker" and either mark the PR as >> "Ready for review" and merge it when it gets green., or manually do >> cherry-picking and resolving conflicts (and also merging it when it gets >> green). >> >> This is quite important - regarding the sequence of merging the - and doing >> it "relatively quickly" - because there might be other PRs that might >> depend on the already cherry-picked PRs - so they might be easier to be >> automatically done by cherry-picker. >> >> Also - waiting for the PR to get green (and either solving or asking for >> help if it's not) is important because it saves the release manager a lot >> of work on figuring out why v3-0-test and v3-0-stable is "red". And it >> makes it easier for the others who cherry-pick PRs after because it avoids >> their "red" cherry-pick that they have no idea where it comes from. >> >> I personally dropped a ball on it over the last few days / weeks and I am >> as guilty as anyone else with merging things too quickly - but also I saw a >> number of cherry-pick PRs that looked abandoned for a few days even if all >> they needed were to make them "Ready for Review". >> >> Maybe a good idea to pay a bit more attention to those when we are merging >> PR that is supposed to be backported. >> >> J. >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org For additional commands, e-mail: dev-h...@airflow.apache.org
