Thanks Jarek for your response and kind words. We will add the integration tests soon.
Jarek Potiuk <ja...@potiuk.com> 于2025年8月4日周一 20:23写道： > > I personally - generally - welcome all the "Apache" projects to contribute > providers. They almost automatically fulfill all the criteria we have for > new providers: > > * they are open-source (and truly open source) > * they have dedicated team of maintainers who "know" how Open Source works > and their intention is to tighten integration and not "drop the code" and > who we can easily ask for help in case of any problems > * this is not a commercial service that has commercial and paid team behind > that could maintain their own provider (even if there are commercial > stakeholders behind, they are not the ONLY ones who can make profit on > that). > * also looking at pyproject.toml of yours, Seatunnel provider is extremely > light in dependencies (just `requests` :) ) -> so I do not see a potential > of disrupting our "all providers workspace dependencies". > * we do not yet have very clear criteria about "popularity" - we have been > discussing it, but looking at the number of stars, forks, and all the > "community insights" and history of the project it looks like a pretty > solid and popular ASF project. I also looked at Board minutes and SeaTunnel > reports [1] (as an ASF Member I also looked at the last report that still > waits for approval and publishing). It looks overall pretty impressive > including number of committers and PMC members - especially the ways how > you guys are actively working on attracting new contributors and performing > outreach to other projects (yes! including Apache Airflow it seems !) and > build your community. I think you are doing a great job. > > So I am very receptive, personally. > > But there is one thing missing - integration tests. > > Since this is an open-source, ASF software, I assume we can run it > standalone without any external service - just having SeaTunnel running > locally - maybe together with a DB of sorts, Seatunnel integrates with > multiple databases - many open-source and many we already have and support > as part of our CI pipelines. So - similarly to Apache Kafka for example - I > think the prerequisite to accepting SeaTunnel will be to have integration > tests added. > > We currently have 17 or so integrations - including Apache Kafka, and > Apache Tinkerpop and having a real "end-2-end" integration tests, helps us > with the condidence that things "continue" to work and that we have an easy > way to reproduce the environment where we can test new versions released > for example. I plan in the future to introduce some regular review and > upgrade of our "integrations" to bump their versions periodically, which > will make it even more maintainable. > > So If you were to ask for LAZY CONSENSUS (if others will not object) or > VOTE - having integration tests implemented is basically a prerequisite for > it. You can read more about integration tests at [2]. If you want to follow > that route, I will be happy to help you with building such integration > tests. > > [1] SeaTunnel Board reports - > https://whimsy.apache.org/board/minutes/SeaTunnel.html > [2] Integration tests - > https://github.com/apache/airflow/blob/main/contributing-docs/testing/integration_tests.rst > > > J. > > On Mon, Aug 4, 2025 at 1:27 PM Jia Fan <fanjia1...@gmail.com> wrote: > > > Thanks haicheng. > > Here is github pr link: https://github.com/apache/airflow/pull/50226 > > and demo link: https://github.com/apache/seatunnel/issues/9178 > > > > haicheng zhang <zhc.oc...@gmail.com> 于2025年8月4日周一 19:19写道： > > > > > > Dear Airflow Developer Community, > > > > > > Hello! > > > > > > We have completed the initial implementation of the Apache > > SeaTunnel > > > Provider for Airflow, including: > > > > > > - Operator/Sensor components for seamless integration - Support for > > > submission, monitoring, and log collection of SeaTunnel jobs > > > > > > - Comprehensive documentation and test cases The code has been submitted > > at > > > [GitHub Link], and detailed design and usage instructions can be found at > > > [Doc/Design Link]. > > > > > > We sincerely invite community members to review and test this provider. > > > Your feedback, suggestions, or issue reports are highly appreciated and > > > will help us further improve the integration. Thank you for your support! > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org > > For additional commands, e-mail: dev-h...@airflow.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@airflow.apache.org For additional commands, e-mail: dev-h...@airflow.apache.org
