Yeah that note makes sense! Thanks & Regards, Amogh Desai
On Fri, Aug 15, 2025 at 12:18 PM Jarek Potiuk <ja...@potiuk.com> wrote: > I also added this when you try to run `breeze static-checks`: > > [image: Screenshot 2025-08-15 at 08.36.30.png] > > https://ibb.co/yBXsFKB6 - if you don't see the image. > > J. > > > > > On Thu, Aug 14, 2025 at 9:09 PM Ferruzzi, Dennis > <ferru...@amazon.com.invalid> wrote: > >> I agree with all those points except loving the name `prek`. The name >> will grow on me, or I'll get used to it; either way it's certainly not a >> blocker. It's always nice to see custom tooling getting replaced by more >> generalized tools that do the same job, sometimes even better. >> >> >> - ferruzzi >> >> >> ________________________________ >> From: Jarek Potiuk <ja...@potiuk.com> >> Sent: Thursday, August 14, 2025 11:49 AM >> To: dev@airflow.apache.org >> Subject: RE: [EXT] [DISCUSS] Upcoming pre-commit -> prefligit change >> >> CAUTION: This email originated from outside of the organization. Do not >> click links or open attachments unless you can confirm the sender and know >> the content is safe. >> >> >> >> AVERTISSEMENT: Ce courrier électronique provient d’un expéditeur externe. >> Ne cliquez sur aucun lien et n’ouvrez aucune pièce jointe si vous ne pouvez >> pas confirmer l’identité de l’expéditeur et si vous n’êtes pas certain que >> le contenu ne présente aucun risque. >> >> >> >> Honestly - I think there is absolutely no need to have the shim after >> rename (and prek name grew on me a lot - it's short, convenient, >> memorable, >> relevant... all you need). And no typosquatting issues. >> >> I am also quite strong on removing `breeze static-checks` altogether. >> People will still be able to use "pre-commit" for a while (until mono-repo >> and more features are added to prek) in parallel and if someone did >> 'pre-commit install` and does once `prek install -f` - and use the >> automated commit workflow this will be a "no-op" change on a daily basis. >> >> Also the `-1500 lines` in https://github.com/apache/airflow/pull/54258 >> speaks for itself. Autocomplete works nicely. >> >> We can always add something later if need be, but I'd prefer a 'clean cut' >> - especially that `prek` will also work with our older branches - >> v3-0-test, v2-11-test etc - they should **just work** (TM). >> >> J. >> >> >> >> >> On Thu, Aug 14, 2025 at 7:56 PM Ferruzzi, Dennis >> <ferru...@amazon.com.invalid> wrote: >> >> > This is really neat, looking forward to it. Faster is gooder! >> > >> > Did we decide not to bother with the airflow-prek/airflow-pre-commit >> shim >> > package, or are we just waiting a bit to see how things land? I'm >> > indifferent, just curious. >> > >> > >> > - ferruzzi >> > >> > >> > ________________________________ >> > From: Jarek Potiuk <ja...@potiuk.com> >> > Sent: Thursday, August 14, 2025 9:01 AM >> > To: dev@airflow.apache.org >> > Subject: RE: [EXT] [DISCUSS] Upcoming pre-commit -> prefligit change >> > >> > CAUTION: This email originated from outside of the organization. Do not >> > click links or open attachments unless you can confirm the sender and >> know >> > the content is safe. >> > >> > >> > >> > AVERTISSEMENT: Ce courrier électronique provient d’un expéditeur >> externe. >> > Ne cliquez sur aucun lien et n’ouvrez aucune pièce jointe si vous ne >> pouvez >> > pas confirmer l’identité de l’expéditeur et si vous n’êtes pas certain >> que >> > le contenu ne présente aucun risque. >> > >> > >> > >> > Quite agree. much snappier in general. >> > >> > On Thu, Aug 14, 2025 at 5:59 PM Daniel Standish >> > <daniel.stand...@astronomer.io.invalid> wrote: >> > >> > > Anecdotally, it does seem faster. >> > > >> > > Autocomplete is nice and all, but nicer is that you don't need to run >> a >> > > specific pre-commit because you can just run the whole shebang, >> because >> > > it's faster. >> > > >> > >> >
