SamWheating opened a new pull request, #54752:
URL: https://github.com/apache/airflow/pull/54752
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
closes: https://github.com/apache/airflow/issues/54141
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This PR adds a `last_parse_time` column to the DAG table, and updates it
during the DAG processing loop. This field is then exposed in the DAG details
API and surfaced to users in the `Code` view like so:
<img width="1916" height="742" alt="Screenshot 2025-08-20 at 11 40 15 AM"
src="https://github.com/user-attachments/assets/dad38a6a-c7aa-4842-8bcd-ed9373ae25d4";
/>
As well as the DAG details pane, like so:
<img width="1914" height="672" alt="Screenshot 2025-08-21 at 4 52 05 PM"
src="https://github.com/user-attachments/assets/a4e4919a-44d9-478f-9c97-b59bac2ecc2e";
/>
Which can be used to identify slow-parsing DAGs without having to look in
the processor logs or metrics.
In the future we could also expose this data elsewhere, for example adding a
"slowest parsing files" table to the cluster overview page, or something
similar.
Anyways, I still need to do a bunch of cleanup here, add new test coverage
and update a bunch of failing tests, but I wanted to get some early feedback on
the implementation here, namely:
- Thoughts on exposing this information on the code tab of the DAG details
page?
- Thoughts on the wording - is `last_parse_duration` / `Parse Duration` the
most accurate naming here? I'm not even sure if my grammar is correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
