jason810496 commented on PR #54050: URL: https://github.com/apache/airflow/pull/54050#issuecomment-3265734562
> Nice. > > One nit here -- with the `AWS_ENDPOINT_URL=http://localstack:4566` env var and the other envs set we shouldn't need to set the connection as you have it. I think we should do one or the other (AWS env vars, or Airflow connection), but not both. If this is the case, do you mean we should the `AWS_ENDPOINT_URL=http://localstack:4566` be set in `scripts/ci/docker-compose/integration-localstack.yml` level? Or would it be better to be set in the test level? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
