potiuk commented on PR #54050: URL: https://github.com/apache/airflow/pull/54050#issuecomment-3268445084
> > One nit here -- with the `AWS_ENDPOINT_URL=http://localstack:4566` env var and the other envs set we shouldn't need to set the connection as you have it. I think we should do one or the other (AWS env vars, or Airflow connection), but not both. > > If this is the case, do you mean we should the `AWS_ENDPOINT_URL=http://localstack:4566` be set in `scripts/ci/docker-compose/integration-localstack.yml` level? Or would it be better to be set in the test level? I think settin `AWS_ENDPOINT_URL` is a good approach actually - it does not really replace the connection, it just changes routing of the client libraries to use localstack instead the default "amazon" connections, so you might use regular "conneciton" and set the variable to make it talk to localstack. I think the best way to make it works in breeze is to change it in `entrypoint_ci.sh` right after "check_environment.sh". We already do a bunch of checks for integrations and do stuff when they are enabled. Something like that: ```bash if [[ ${INTEGRATION_LOCALSTACK} == "true" ]]; then export AWS_ENDPOINT_URL=http://localstack:4566 fi ``` Then everything started with `--integration localstack` will automatically use localstack regardless what connections are defined. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
