ashb commented on code in PR #55458:
URL: https://github.com/apache/airflow/pull/55458#discussion_r2337106299
##########
.github/workflows/basic-tests.yml:
##########
@@ -394,3 +394,41 @@ jobs:
run: |
breeze release-management generate-issue-content-core \
--limit-pr-count 2 --previous-release 3.0.1 --current-release
3.0.2 --verbose
+
+ test-airflow-standalone:
+ timeout-minutes: 30
+ name: "Test Airflow standalone command"
+ runs-on: ${{ fromJSON(inputs.runners) }}
+ env:
+ PYTHON_MAJOR_MINOR_VERSION: "${{ inputs.default-python-version }}"
+ steps:
+ - name: "Cleanup repo"
+ shell: bash
+ run: docker run -v "${GITHUB_WORKSPACE}:/workspace" -u 0:0 bash -c "rm
-rf /workspace/*"
+ - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
+ uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 #
v4.2.2
+ with:
+ persist-credentials: false
+ - name: "Install Breeze"
+ uses: ./.github/actions/breeze
+ - name: "Test airflow standalone command"
+ run: |
+ # Start airflow standalone and wait for "Airflow is ready" message
+ timeout 600s breeze run bash -c "
+ airflow standalone 2>&1 | tee /tmp/airflow.log &
+ AIRFLOW_PID=\$!
+
+ for i in {1..600}; do
Review Comment:
This is going to loop for the full 10 minutes even if the process crashes
after 1 second. `kill -0 $AIRFLOW_PID` will return 0/success if the process is
still alive without sending it any signal.
And if we wanted to get the exit code we could then do `wait $AIRFLOW_PID;
status=$?` but given it should stay alive until killed it's not all that useful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
