Thanks for clarifying that for the community Jakob. It's not always clear to a submitter whether they have received a +1 from a committer or not and could lead to confusion as to whether they have received a +1 but are just waiting for a merge.
I think the Jira "vote" feature avoids this confusion and feel that is a better way forward. It has the added benefit of capturing votes for abandoned or closed-but-not-merged PRs. -s On Tue, Oct 11, 2016 at 1:19 PM, Jakob Homan <jgho...@gmail.com> wrote: > Be sure to distinguish between +1 == I want this, and +1 == I approve > this change to be merged into the codebase. > > Non-committers are welcome and encouraged to review patches, including > providing +1s. The patch can't be merged on the basis of that > non-committer +1 only (a committer's +1 is still required), but this > is good experience and contribution from the non-committer. > > > On 11 October 2016 at 12:16, Laura Lorenz <llor...@industrydive.com> > wrote: > > I started to do this and totally got myself stuck answering bug reports > 😅🙃 > > > > On Mon, Oct 10, 2016 at 11:33 PM, siddharth anand <san...@apache.org> > wrote: > > > >> Great idea, Max. > >> > >> There is also a vote feature on JIRAs. Sometimes PRs get abandoned, > whereas > >> the JIRA tends to stick around longer, sometimes even without an owner. > I'm > >> not sure which is the best way, but I completely agree with the > sentiment. > >> > >> -s > >> > >> On Mon, Oct 10, 2016 at 6:01 PM, Maxime Beauchemin < > >> maximebeauche...@gmail.com> wrote: > >> > >> > Airflowers, > >> > > >> > I would love if people could write simple `+1` comments on the PRs > they > >> > care about. > >> > > >> > It's motivating for contributors to see that people want the features > >> they > >> > work on, and it can help committers prioritize which PRs to review and > >> > release first. > >> > > >> > It's also a great way to keep a pulse on the project, see what is > coming > >> > up, and to start getting involved. Of course more involved feedback > >> > (reaction icons, comments, review) are also very welcomed. > >> > > >> > See you on Github! > >> > > >> > Max > >> > > >> >
