- **status**: code-review --> in-progress
- **QA**: Dave Brondsema
- **Comment**:
* `auth.allow_edit_prefs` should default to True in the code.
* These were most likely pre-existing, but can you fix them up now too?
* If you hit "Enter" from the Display Name field (rather than hitting Save
below) you get an error.
* hitting 'Claim New Address' without entering an address ends up with a
weird address record. Invalid addresses (i.e. not email address format) are
incorrectly permitted too.
* Yes, the ssh key form should be hidden by default. I think it was intended
to be used with this configuration
https://forge-allura.apache.org/docs/scm_host_ssh.html Can you add blocks &
config options for it, and the password change form, and the user messages
section? (And you can remove `{% if c.password_change_form %}` then too, I
think its unnecessary). Default the ssh key form to False and the rest to True.
---
** [tickets:#7436] /auth/preferences cleanup**
**Status:** in-progress
**Milestone:** limbo
**Labels:** 42cc
**Created:** Tue Jun 03, 2014 07:44 PM UTC by Dave Brondsema
**Last Updated:** Fri Jun 06, 2014 08:48 AM UTC
**Owner:** nobody
* Add a section at the top of readonly information, show:
* Username: {{username}}
* `<a href="{{user.private_project().url()}}">My profile and my
projects</a>`
* `<a href="{{user.private_project().url()}}admin/overview">Set avatar
icon</a>`
* `password_change_form` and `upload_key_form` shouldn't be tied to the theme.
Move the forms to a better place (auth something..)
* Make every part of the page (`password_change_form` and `upload_key_form`,
Display Name, Page Size, Email, User Messages, etc in a unique jinja block.
Instead of "if" statements that check `auth.method` or the theme, every section
on the page should be contained in a block so that a simple [template
override](https://forge-allura.apache.org/docs/api/lib/package_path_loader.html)
can be set up for `user_prefs.html` and any individual block can be made to be
empty (or something else)
* Improve the layout between each section as best you can. And within the
email block especially. It seems like everything is just run together. It is
extra confusing that there a multiple separate forms with their own save
buttons. I think dedicated forms for pwd change and ssh keys makes sense, but
it is confusing to have so many forms on the page. I am open to suggestions
for the multiple forms issue. Best idea I have so far is to have a `<hr>`
between each form, to visually show the separations. (Ideally would have it
all auto-save ajax or all one single form, but those would be big projects).
---
Sent from sourceforge.net because [email protected] is subscribed to
https://sourceforge.net/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a
mailing list, you can unsubscribe from the mailing list.
