- **status**: review --> in-progress
- **Comment**:
The new form of `paged_diffs` which uses `log` looks much better than the old
logic in `refresh_commit_info` which used `info2`. However the `ClientError`s
that the old implementation handled seem to still be something we need to
address. I tried importing https://svn.code.sf.net/p/tango-ds/code/ since I
knew it had those "non-existent in revision" errors. It is a big repo (took
few hours to import and index); I'm sure you can find others that are smaller
that exhibit it problem. If you run a refresh on master you can see the
revisions it complains about. Then on your branch, go to the commit view for
that revision + 1. It will show no changed files, but it should show some
(compared to master). It does seem to know how many changes there are, because
e.g. https://sf-dbrondsema-1015.sb.sf.net/p/project2/tango-ds/15818/ lists 3
pages (but no items on those pages).
I dug into it a little bit and apparently `p['action'] == 'R'` so we need to
figure out what to do with that. I'd also recommend adding this so any
`ClientError` that might happen does not get swallowed:
~~~~
::diff
except pysvn.ClientError:
+ log.info('Error getting paged_diffs log of %s on %s', commit_id,
self._url, exc_info=True)
return result
~~~~
---
** [tickets:#7837] Use repo directly instead of DiffInfoDoc**
**Status:** in-progress
**Milestone:** unreleased
**Labels:** 42cc sf-8 sf-current indexless
**Created:** Fri Feb 20, 2015 10:40 PM UTC by Dave Brondsema
**Last Updated:** Thu Mar 12, 2015 03:50 PM UTC
**Owner:** Igor Bondarenko
See [#7828] for analysis of where DiffInfoDoc is used. Goal is to remove it
altogether, using SCM data directly. Then also remove the building of
DiffInfoDoc records during repo refresh. (If there are really slow
computations we could keep using DiffInfoDoc for a cache of those results)
---
Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed
to https://forge-allura.apache.org/p/allura/tickets/
To unsubscribe from further messages, a project admin can change settings at
https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is
a mailing list, you can unsubscribe from the mailing list.
