- **status**: review --> in-progress
- **Comment**:

FYI your new branch is ib/7873 and previous was ib/7837 :)

I think sometimes 'R' is used when it's not *really* a replacement, but we can 
only work with the data we get.  I think the 'R' might come from situations 
like this http://svn.haxx.se/users/archive-2005-06/0711.shtml particularly when 
tagging repositories since trunk/tags/branches checkouts might be separate on 
the machine of the person doing the tagging.  Perhaps we could do some 
heuristics to see if the file existed in the previous revision, but lets not go 
down that path yet :)  I think we can live with this.

I'm seeing an 'added' directory not showing up.  Example: tango-ds r98.  The 
paged_diffs method returns it `{'total': 3, 'removed': [], 'added': 
[u'/Servers/Acquisition/Ccd/ExampleServer/tags/Release_2_1'], 'changed': 
[u'/Servers/Acquisition/Ccd/ExampleServer/tags/Release_2_1/Makefile', 
u'/Servers/Acquisition/Ccd/ExampleServer/tags/Release_2_1/Pilatus.cpp']}` but 
the added folder does not show up in the template.  (Perhaps some unrelated 
bug, but might as well fix now)

I also note that SVN provides the copied from information (`p.copyfrom_path`) 
for that 'added' file.  If that is present, can we use status 'copied' and set 
the `.old` and `.new` attributes so that `repo/commit.html` will show it?



---

** [tickets:#7837] Use repo directly instead of DiffInfoDoc**

**Status:** in-progress
**Milestone:** unreleased
**Labels:** 42cc sf-8 sf-current indexless 
**Created:** Fri Feb 20, 2015 10:40 PM UTC by Dave Brondsema
**Last Updated:** Mon Mar 16, 2015 03:18 PM UTC
**Owner:** Igor Bondarenko

See [#7828] for analysis of where DiffInfoDoc is used.  Goal is to remove it 
altogether, using SCM data directly.  Then also remove the building of 
DiffInfoDoc records during repo refresh.  (If there are really slow 
computations we could keep using DiffInfoDoc for a cache of those results)


---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed 
to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.

Reply via email to