On 3/24/17 9:21 AM, Nadun Indunil wrote: > Hi Dave, > > Regarding the pagination controls are used in many places : > I will send you screenshots of the appearance of pagination in other places > as well. > > Regarding the using ajax and "more": > My idea was adding "more" link to show reply posts of post as we see in > Facebook. correct me if I have followed you incorrectly.
Yep, that's the idea. > I went through the code and found few places which use ajax requests and > the implementations are somewhat different from each other. > some are in js files and some in server files and few in html (view) files > as well. > could you please provide more information about how and where to implement > the "more" link in discussion. The discussion thread HTML is created by allura/templates/widgets/thread_widget.html and the subsequent "widgets" that it calls (post_thread and page_list). Figuring out how the "widgets" are called and defined can be a little tricky since they are in python (e.g. for post_thread, it is PostThread) and that has its own HTML file (post_thread.html). Same for the page_list widget for pagination. So the link would probably have to go in thread_widget.html near the pagination. Corresponding JS is in allura/lib/widgets/discuss.py class Thread. Unfortunately that is embedded within a .py file which is kind of gross :( It would be good to refactor at some point into a separate file like those at Allura/allura/lib/widgets/resources/js/ The other part of AJAX of course is the content to retrieve. You will need a controller to return the contents of "more" data. Since discussion threads are used in so many places, it'll have to be something that works with forums, tickets, wikis, blog comments, etc. Fortunately I think all those tools have a "_discuss" URL path that uses the same AppDiscussionController already. That could be a place server-side to load up the next pages to return to the browser. > > thank you. > > On 24 March 2017 at 03:15, Dave Brondsema <d...@brondsema.net> wrote: > >> Hi Nadun, >> >> No problem.. and sorry for my slow reply :) >> >> The UI of these pagination controls definitely seems better: bigger things >> to >> click on than just the text is good! I wonder if (Page 2 of 3) is >> needed? You >> can see your current page because it is highlighted now. Perhaps put (3) >> in the >> Last button like "Last (3)"? Just an idea, not 100% sure if it would be >> good or >> not. >> >> I noticed your screenshot is on the Tickets list page. Pagination >> controls are >> used on many places all over Allura, so that is good to see how this looks >> in >> many places. >> >> Have you thought about the other parts of ticket #5709 like using Ajax and >> a >> "more" link? The 3rd bullet point about reply/link/edit/delete taking up >> space >> is actually outdated - that isn't true since some changes last summer. >> Spacing >> around the avatar can be improved though. >> >> Thanks for sharing your ideas so far - if you're thinking about Google >> Summer of >> Code, it's good to ask questions and post ideas here to get feedback for >> your >> proposal. >> >> >> On 3/21/17 1:21 PM, Nadun Indunil wrote: >>> Hi Dave, >>> >>> sorry for the inconveniences, please find the screen shot from the link >>> below. >>> >>> https://drive.google.com/file/d/0B0YOxEOQ5qjTNmpLcGJvSG8tRU0/ >> view?usp=sharing >>> >>> thank you. >>> >>> On 21 March 2017 at 22:45, Dave Brondsema <d...@brondsema.net> wrote: >>> >>>> Hey Nadun, >>>> >>>> Attachments don't work on this list :( Can you upload the screenshot >>>> somewhere >>>> and send a link? >>>> >>>> Thanks! >>>> >>>> On 3/21/17 1:04 PM, Nadun Indunil wrote: >>>>> Hi all, >>>>> >>>>> I was working on the problem of pagination in *Allura Tickets tool *and >>>> I added >>>>> few styles into the project. I have attached a screen shot of the new >>>>> implementation. could you please consider the attached image and let me >>>> know any >>>>> improvements need to be done. >>>>> >>>>> -- >>>>> Regards, >>>>> >>>>> >>>>> >>>>> *Nadun Indunil* >>>>> >>>>> Department of Computer Science & Engineering >>>>> >>>>> University of Moratuwa >>>>> >>>>> >>>>> Mobile: +94719201680 >>>>> >>>>> Skype: nadun_indunil >>>>> >>>>> Website: http://nadunindunil.github.io <http://nadunindunil.github.io/ >>> >>>>> >>>>> Blog: http://nadunindunil.github.io/tech/ >>>>> >>>>> *Github:* https://github.com/nadunindunil >>>>> >>>>> >>>>> linkedin.png <https://www.linkedin.com/in/nadun-indunil-32557696/> >>>> facebook.png >>>>> <https://www.facebook.com/nadun.indunil>twitter.png >>>>> <https://twitter.com/nadmatrix>instagram.png >>>>> <https://www.instagram.com/nadunindunil/> >>>>> >>>> >>>> >>>> >>>> -- >>>> Dave Brondsema : d...@brondsema.net >>>> http://www.brondsema.net : personal >>>> http://www.splike.com : programming >>>> <>< >>>> >>> >>> >>> >> >> >> >> -- >> Dave Brondsema : d...@brondsema.net >> http://www.brondsema.net : personal >> http://www.splike.com : programming >> <>< >> > > > -- Dave Brondsema : d...@brondsema.net http://www.brondsema.net : personal http://www.splike.com : programming <><
