Hi.. I've updated the task calls and pushed to ss/8323. Btw as you mentioned there needs to be some test coverage So we can add a test to `TestNotificationTasks.test_send_usermentions_notification` ?
We can use `with mock.patch.object(mail_tasks.smtp_client, '_client') as _client:` as in mail tasks I guess. Could you advice your points about test coverage Thanks --- ** [tickets:#8323] gsoc19 - Trigger notification task per each artifact creation/modification and add tests** **Status:** open **Milestone:** unreleased **Labels:** gsoc19 **Created:** Mon Aug 12, 2019 04:50 PM UTC by Shalitha Suranga **Last Updated:** Wed Aug 14, 2019 07:14 PM UTC **Owner:** Shalitha Suranga Add a test for the send_usermentions_notification task. Also.. `send_usermentions_notification` task is only called in a few places so far, but would be good to do in all the places where a new artifact is created/modified(content) (new wiki page, new ticket, new blog post, new merge request). Maybe a new ticket for all that together. --- Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed to https://forge-allura.apache.org/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://forge-allura.apache.org/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
