Looking good.... adding a test in `TestNotificationTasks` would be good.  I 
think with sample test data there, there should be a wiki `Page` artifact 
created that you could query for.  Or make a new artifact of some type.  And 
then use that to call `send_usermentions_notification`

And the `mock` example you gave is good too.  That way you can make assertions 
about what actual mails got sent out.


---

** [tickets:#8323] gsoc19 - Trigger notification task per each artifact 
creation/modification and add tests**

**Status:** review
**Milestone:** unreleased
**Labels:** gsoc19 
**Created:** Mon Aug 12, 2019 04:50 PM UTC by Shalitha Suranga
**Last Updated:** Sun Aug 18, 2019 07:06 AM UTC
**Owner:** Shalitha Suranga


Add a test for the send_usermentions_notification task. Also.. 
`send_usermentions_notification` task is only called in a few places so far, 
but would be good to do in all the places where a new artifact is 
created/modified(content) (new wiki page, new ticket, new blog post, new merge 
request). Maybe a new ticket for all that together.


---

Sent from forge-allura.apache.org because dev@allura.apache.org is subscribed 
to https://forge-allura.apache.org/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://forge-allura.apache.org/p/allura/admin/tickets/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.

Reply via email to