----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17596/#review33374 -----------------------------------------------------------
This patch doesn't address the real issue - that being the port lookup in AbstractProviderModule is not returning (or finding) a value for ambari.dfs.datanode.http.port. The error propagates itself in JMXPropertyProvider when the URL "spec" is being built. - Nate Cole On Jan. 31, 2014, 4:47 p.m., Dmytro Shkvyra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17596/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2014, 4:47 p.m.) > > > Review request for Ambari, Mahadev Konar, Nate Cole, Tom Beerbower, and > Yusaku Sako. > > > Bugs: AMBARI-4490 > https://issues.apache.org/jira/browse/AMBARI-4490 > > > Repository: ambari > > > Description > ------- > > The cause of error messages is that we start use new format properties like > "dfs.datanode.http.address":"0.0.0.0:${ambari.dfs.datanode.http.port}". > It means that we have to replace ${ambari.dfs.datanode.http.port} with value > of ambari.dfs.datanode.http.port property from current config. > In this case we need process these value references and keep in mind that: > 1) We can have some references in one property, like this > "dfs.datanode.http.address":"${ambari.dfs.datanode.http.host}:${ambari.dfs.datanode.http.port}" > 2) Also value references can be referenced to another references. > 3) Patch have to impact all configs > So, I have created private method postProcessPropertyValue in > ResourceImpl.java for resolve all of value references > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ResourceImpl.java > 15fb961 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ResourceImplTest.java > da87bc6 > > Diff: https://reviews.apache.org/r/17596/diff/ > > > Testing > ------- > > Added unitests > > > Thanks, > > Dmytro Shkvyra > >
