> On Feb. 2, 2014, 11:04 a.m., Tom Beerbower wrote:
> > I'm confused. Are there 2 separate issues here? What does the property
> > token replacement have to do with Ganglia not being installed? It seems
> > like it would be an issue whether Ganglia was installed or not. Could you
> > explain?
> >
> > On the property replacement ... If it is a requirement that the framework
> > replace the tokens with property values from the config then I like a
> > generic approach. I'm just worried that you may be applying it too
> > broadly. Could there ever be cases where we don't want the ${} token to be
> > replaced? I guess that a resource provider could use a different Resource
> > implementation if that were the case. Maybe it's okay if we really want to
> > say that this should be the default behavior.
> >
> > One thing that I don't like is how the property value must be checked every
> > time getProperty() is called? Why not just do it once on setProperty()?
> >
> > Also, on your Note to Nate ... I think that these reviews are public, so we
> > probably shouldn't mention internal Jiras.
I have done some tests and reveal that properties do not replace so broadly as
need. Current do not replaced property values while install configs on nodes.
Second one, it replace properties in UI, and as far as understood, this is not
needed.
Please wait, I'll looking for solution.
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17596/#review33393
-----------------------------------------------------------
On Feb. 3, 2014, 6:11 p.m., Dmytro Shkvyra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17596/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2014, 6:11 p.m.)
>
>
> Review request for Ambari, Mahadev Konar, Nate Cole, Tom Beerbower, and
> Yusaku Sako.
>
>
> Bugs: AMBARI-4490
> https://issues.apache.org/jira/browse/AMBARI-4490
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The cause of error messages is that we start use new format properties like
> "dfs.datanode.http.address":"0.0.0.0:${ambari.dfs.datanode.http.port}".
> It means that we have to replace ${ambari.dfs.datanode.http.port} with value
> of ambari.dfs.datanode.http.port property from current config.
> In this case we need process these value references and keep in mind that:
> 1) We can have some references in one property, like this
> "dfs.datanode.http.address":"${ambari.dfs.datanode.http.host}:${ambari.dfs.datanode.http.port}"
> 2) Also value references can be referenced to another references.
> 3) Patch have to impact all configs
> So, I have created private method postProcessPropertyValue in
> ResourceImpl.java for resolve all of value references
>
>
> Diffs
> -----
>
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ResourceImpl.java
> 15fb961
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ResourceImplTest.java
> da87bc6
>
> Diff: https://reviews.apache.org/r/17596/diff/
>
>
> Testing
> -------
>
> Added unitests
>
>
> Thanks,
>
> Dmytro Shkvyra
>
>
